Closed Arcus92 closed 4 weeks ago
Latest commit | 35864a1 |
---|---|
Status | 🔄 Deploying... |
Preview URL | Not available |
Type | 🔀 Preview |
@ferferga Yes, it is working just fine. Like the default web interface I would like to add a opt-in option in the subtitle settings. However, I had no time to look into the setting menu in vue yet. Maybe this weekend.
@ferferga Just noticed there aren't any subtitle settings at the moment. Is it okay to just leave it enabled for now?
Btw. here is it working in vue:
@Arcus92 The subtitle settings are being worked on in https://github.com/jellyfin/jellyfin-vue/pull/2360 After your perf improvements in your library, is there any good reason for keeping the opt-in setting for rendering? (I'd say it should be opt-out in Vue as well, given this client targets evergreen browsers and modern platforms, unlike web).
It should be fine performance wise. I haven't tested different server architectures yet. Ripping .sup files from the source is an intensive task. Worst case ffmpeg could run out of memory or cache disk space and block playback or crash the server. Currently this is just my unfounded fear. For web, I just wanted to be extra safe because this a brand new feature. Since vue is already experimental we could just enable it - with your permission - and wait for some feedback. Best case no one will notice the difference.
@Arcus92 It's completely alright for me. I'll fix the conflicts and ship it later today!
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Changes This PR allows the client to request and render native PGS subtitle streams without transcoding. PGS is a graphical subtitle format. The subtitles are rendered locally by the client on-top of the video element.
This adds a new dependency libpgs-js. I just created this library for the Jellyfin project. If desired, you can fork it into the https://github.com/jellyfin domain.
Related Pull Request (backend): https://github.com/jellyfin/jellyfin/pull/12056 Related Pull Request (web): https://github.com/jellyfin/jellyfin-web/pull/5688