search

jellyfin / jellyfin-vue

A modern web client for Jellyfin based on Vue
https://jellyfin.org
GNU General Public License v3.0
1.26k stars 226 forks source link

Item select version & video ist broken #462

Closed schmidex closed 3 years ago

schmidex commented 3 years ago

First of all thanks for your hard work. This looks very promising! Just want to let you know, that I came across a small bug on the item page. See screenshot. https://github.com/jellyfin/jellyfin-vue/blob/96c1210a5c8092bb6f84f16d04448393792979d6/pages/item/_itemId/index.vue#L126 needs to be {{ i.value.Name}}. But I couldn't figure out how to fix the dropdown :-( The Label of the version-select is also wrong (says 'Video').

select

ThibaultNocchi commented 3 years ago

I'm looking into it, I surely broke that recently :)

schmidex commented 3 years ago

thanks for the quick fix. Another thing I noticed now: When selecting another version in the dropdown the other options don't update accordingly. For example: When I change the version from a 4K to a 1080p source, the video still says "4K HEVC HDR"."

ThibaultNocchi commented 3 years ago

I think it was never implemented, am I right? Either way, I could do this soon I guess

heyhippari commented 3 years ago

It is indeed not implemented yet. The selectors are "just for show", in order to have them visually on the page for design purposes.