search

jellyfin / jellyfin-vue

A modern web client for Jellyfin based on Vue
https://jellyfin.org
GNU General Public License v3.0
1.29k stars 229 forks source link

Top right fab buttons focus problem #553

Closed ThibaultNocchi closed 3 years ago

ThibaultNocchi commented 3 years ago

The fab buttons (dark mode and language) both have the same focus problem we had with the (now removed) fab buttons of the audio player (@ferferga). Maybe we should apply the same fix?

camc314 commented 3 years ago

What did we do to fix in the audio player?

ThibaultNocchi commented 3 years ago

Applied weird CSS classes ^^

ThibaultNocchi commented 3 years ago

https://github.com/jellyfin/jellyfin-vue/blob/55f58f675e1153637e0573f794d70e780ede52ba/components/Layout/AudioControls.vue#L301

camc314 commented 3 years ago

Ah

We might want to use:

https://github.com/vuetifyjs/vuetify/issues/8172#issuecomment-738304152

to enable hovering

ThibaultNocchi commented 3 years ago

Yup, might be worth a shot!

stale[bot] commented 3 years ago

Issues go stale after 60 days of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 14 days of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media.