search

jellyfin / jellyfin-vue

A modern web client for Jellyfin based on Vue
https://jellyfin.org
GNU General Public License v3.0
1.29k stars 229 forks source link

HTML formatting broken #813

Closed Bitwolfies closed 1 year ago

Bitwolfies commented 3 years ago

Describe The Bug

Descriptions with HTML tags fail to display properly

  1. Add a book, one with html tags
  2. see that it does not display them right

Expected Behavior to have html tags

Screenshots Screenshot 2021-03-01 031440

System (please complete the following information):

heyhippari commented 3 years ago

We discussed this a bit internally.

Technically, this feature is already in jf-vue. However, the server escapes characters to be safer.

One thing though, is that we'd like to keep some kind of unified look to the client, which doesn't mesh well with somewhat random HTML in item descriptions.

In addition to that, not all providers give us HTML, and those that do may just get wrecked by the sanitation we do in jf-vue for safety (Something jf-web doesn't do).

As a result, we've decided to not support HTML tags past the <br> one, and to make the display nicer, we will be unescaping the overviews and removing all HTML except this one type of tag.

Further down the line, we would like to explore a limited set of markdown formatting, though a caveat is that no current provider supports this. This would, if it happens, be limited to at most bold, italics and a special type of link between items on the server (So that an overview mentioning an item you have, like an album by an artist, would link to it).

You can find the related changes for what I explained in the first part in #816.

ThibaultNocchi commented 3 years ago

Fixed by #816

Bitwolfies commented 3 years ago

Fixed by #816

If you mean it its meant to hide the html tags, it dont.

ThibaultNocchi commented 3 years ago

Oh shoot haha, thanks for noticing it!

Bitwolfies commented 3 years ago

Oh shoot haha, thanks for noticing it!

Oh its not just me thank god, that pr was merged when I made the issue, so I updated but nothing changed, wondered if I did something wrong.

stale[bot] commented 3 years ago

Issues go stale after 60 days of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 14 days of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media.

Bitwolfies commented 3 years ago

still exists

stale[bot] commented 3 years ago

Issues go stale after 60 days of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 14 days of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media.

Bitwolfies commented 3 years ago

Existence

stale[bot] commented 3 years ago

Issues go stale after 60 days of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 14 days of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media.

carif commented 2 years ago

Further down the line, we would like to explore a limited set of markdown formatting, though a caveat is that no current provider supports this. This would, if it happens, be limited to at most bold, italics and a special type of link between items on the server (So that an overview mentioning an item you have, like an album by an artist, would link to it).

While this comment is old, I just wanted to say that I would love to see some support for lists in an item description. I'm currently using html lists in jf-web to document the reading-order of some more complex book series. ^^ (Book 1, Book 10 Chapter 1, Book 2, Book 10 Chapter 2.. stuff like that.. kind of the problem when the in-between stories only got published, bundled in one book, after the series was over)

ferferga commented 1 year ago

@Bitwolfies Can you try now that the client is running on Vue 3? I don't have any item with HTML descriptions, sorry.

nielsvanvelzen commented 1 year ago

FYI; item & server descriptions should support both Markdown and HTML. I believe both jellyfin-web and jellyfin-androidtv are the only clients supporting it right now.

Bitwolfies commented 1 year ago

@Bitwolfies Can you try now that the client is running on Vue 3? I don't have any item with HTML descriptions, sorry.

Sorry, Ill be away from my server still till mid may, but I trust you guys enough to assume you've fixed it, thanks!