jellyfin / jellyfin-vue

A modern web client for Jellyfin based on Vue
https://jellyfin.org
GNU General Public License v3.0
1.26k stars 226 forks source link

UI crashes on page reloads #914

Closed lyarenei closed 3 years ago

lyarenei commented 3 years ago

Describe The Bug The UI crashes when reloading specific pages. The only reload which works correctly is when on homepage.

Reloading the page while browsing the library results in empty library message. All libraries on the left panel are gone. Clicking on Home or my username doesn't do anything. Same for the theme button. The only recovery from this state is to reload the whole app via server URL (hit enter in URL bar).

Reloading the page while on album details results in HTTP 500 error logged in console. Going back doesn't help, only reload via server URL as described above helps. The URL must be for the server, without/musicalbum/id. This applies to TV shows and movies as well (with their own respective URL paths).

Reloading page on settings results in similar state as library, but the error in console is different.

Steps To Reproduce

For library

  1. Log in to jellyfin.
  2. Go to your library of choice
  3. Reload the page in browser
  4. Library is shown as empty and UI elements don't work

For album/tv show/movie

  1. Log in to jellyfin.
  2. Go to your library of choice
  3. Open a library item of your choice
  4. Reload the page in browser
  5. Error page is displayed

Expected Behavior Everything reloads properly, like on a homepage. UI elements works as expected.

Logs Shown in the screenshots below

Screenshots Library after reload

image

Album after reload

image

Settings page after reload

image

System (please complete the following information):

Additional Context Safari was tested with all addons disabled. Firefox was tested with my usual set of addons enabled.

ThibaultNocchi commented 3 years ago

Hey, thanks for the report, I can confirm this

ferferga commented 3 years ago

@ThibaultNocchi @lyarenei Is this still happening?

I can't reproduce it

ThibaultNocchi commented 3 years ago

I haven't tried but it should be fixed by #926

Edit: I confirm it should be fixed

lyarenei commented 3 years ago

@ferferga Sorry, I didn't notice any updates on this.

I quickly tested the ssr.2021-04-07.e3359b9 release. Reload of a library - works Reload of an album - works Reload of a movie - works Reload of a tv show episode - works Reload of settings - still breaks as described Reload of a TV show - error page is not displayed anymore, but episode list disappears for that particular show until the app is reloaded via URL. Other shows are displayed fine and no errors in browser console are logged.

ThibaultNocchi commented 3 years ago

I confirm this

stale[bot] commented 3 years ago

Issues go stale after 60 days of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 14 days of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media.

ferferga commented 2 years ago

Fixed by #1632