jellyfin / jellyfin-web

Web Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.35k stars 1.25k forks source link

Subtitles obscured by playback controls UI #2441

Closed CloudStu closed 3 years ago

CloudStu commented 3 years ago

Describe The Bug After updating Jellyfin, I've found the player controls take up much more screen real estate, with superfluous information like the Rotten Tomatoes score and other ratings. This covers the subtitles, making it more difficult to read them when the controls UI is active. This is not an issue whilst the video is paused, but is frustrating when using the controls whilst the video is playing, such as changing volume using the Subtitles Offset feature, or any other playback settings.

Steps To Reproduce Play any video with subtitles and interact with the controls.

Expected Behavior I would expect one of:

Personally I don't find the expanded UI adds anything useful to the playback of the video (Film Ratings), prefering a more minimal UI with fewer visual distractions, but this was presumably added for a reason. It isn't a big problem having the extended info when paused, so I offer the suggestions to move the subtitles or hide the playback controls when in Subtitles Offset.

Screenshots

image Above is a screenshot from Firefox. However its worse on my LG TV: image

System:

Additional Context I immediately noticed this change after updating my LinuxServer.io Jellyin installation over the weekend to 10.6.4-1-ls97. I apologise I don't know what version I was on previously - one of the pitfalls of using docker-compose with the 'latest' tag means I couldn't easily see what version I was using beforehand. This also means I can't show you any screenshots from before this behaviour regressed, nor can I even tell you specifically what changed, but I know I was immediately frustrated - something has changed.

Where I sometimes have poorly synced subtitles I find myself using Subtitles Offset multiple times an episode, which is why this issue is so noticeable to me.

heyhippari commented 3 years ago

Do note we've redesigned the OSD in 10.7, so this is less of an issue: image

The OSD was pretty much unchanged before, only the way the subtitles are displayed may have changed since the last version you used.

CloudStu commented 3 years ago

Ah! I must have been using 10.7 without realising. I updated this weekend to the latest stable release after I saw it fixed the hardware acceleration issue due to intel drivers on my Gemini Lake CPU. A month or so ago I had been trying all sort of versions and releases, including unstable, in an effort to fix it. I must have settled on a 10.7 version.

Your screenshot actually looks exactly like what I saw previously. Much less frustrating! Apologies for the noise, I will close this issue.