search

jellyfin / jellyfin-web

Web Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.28k stars 1.22k forks source link

Missing Weblate string #2671

Open nextlooper42 opened 3 years ago

nextlooper42 commented 3 years ago

Describe The Bug String that cannot be translated in Weblate. To be exact, there is no such string to translate.

Steps To Reproduce

  1. Change language to for example slovak
  2. Open some random tv show
  3. You'll see untranslated string "Aired on"

Expected Behavior Be able to translate every part of Jellyfin.

Screenshots untranslated

System (please complete the following information):

dmitrylyzo commented 3 years ago

This function needs to be rewritten: https://github.com/jellyfin/jellyfin-web/blob/8232d2dade854a6125a36e6b83c8f9c51463895e/src/controllers/itemDetails/index.js#L1305-L1344

It just concatenates Aired|Airs, daily|<ListOfDays>, at <Time> and on <Studio>. I suppose we need multiple translation strings (24 in total :eyes: ) like:

"Aired": "Aired",
"AiredOnStudio": "Aired on {1}",
"AiredDailyOnStudio": "Aired daily on {1}",
"AiredDaysAtTime": "Aired {1} at {2}",
"AiredDaysAtTimeOnStudio": "Aired {1} at {2} on {3}"
...
"Airs": "Airs",
"AirsOnStudio": "Airs on {1}",
"AirsDailyOnStudio": "Airs daily on {1}",
"AirsDaysAtTime": "Airs {1} at {2}",
"AirsDaysAtTimeOnStudio": "Airs {1} at {2} on {3}"
...

Or somehow combine the translatable parts into a valid sentence. Or split the sentence into separate fields: AirState, AirTime, AirStudio.