jellyfin / jellyfin-web

Web Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.31k stars 1.23k forks source link

Too many albums by artist #2757

Closed ghost closed 3 years ago

ghost commented 3 years ago

Describe the bug

System (please complete the following information):

To Reproduce

  1. Click on an artist
  2. See that there is every album that artist ever participated to.

Expected behavior

See only album by the artist.

Logs

Screenshots

Screenshot_20210423_214302

Additional context

I'm pretty sure the problem come from jellyfin mixing up "artist" and "albumartist". Example of album.nfo :

<?xml version="1.0" encoding="utf-8" standalone="yes"?>
<album>
  <review />
  <outline />
  <lockdata>false</lockdata>
  <dateadded>2021-01-12 20:29:51</dateadded>
  <title>The Unauthorized Bash Brothers Experience</title>
  <year>2019</year>
  <premiered>2019-05-23</premiered>
  <releasedate>2019-05-23</releasedate>
  <runtime>26</runtime>
  <genre>Comedy</genre>
  <genre>Hip Hop</genre>
  <musicbrainzalbumid>37cb7215-e6fb-443c-95c1-421fbb9b167b</musicbrainzalbumid>
  <musicbrainzreleasegroupid>a792462c-c76d-43b3-a62d-a29ac2ff055a</musicbrainzreleasegroupid>
  <art>
    <poster>/data/music/The Lonely Island/The Lonely Island - ALBUM - 2019 - The Unauthorized Bash Brothers Experience/folder.jpg</poster>
  </art>
  <artist>HAIM</artist>
  <artist>Maya Rudolph</artist>
  <artist>Sia</artist>
  <artist>The Lonely Island</artist>
  <artist>The Unauthorized Bash Brothers Experience</artist>
  <albumartist>The Lonely Island</albumartist>
  <track>
    <position>1</position>
    <title>Jose &amp; Mark</title>
    <duration>02:25</duration>
  </track>
  <track>
    <position>2</position>
    <title>Uniform On</title>
    <duration>01:45</duration>
  </track>
  <track>
    <position>3</position>
    <title>Let’s Bash</title>
    <duration>02:23</duration>
  </track>
  <track>
    <position>4</position>
    <title>Oakland Nights</title>
    <duration>03:13</duration>
  </track>
  <track>
    <position>5</position>
    <title>Focused AF</title>
    <duration>01:55</duration>
  </track>
  <track>
    <position>6</position>
    <title>Focus on the Game</title>
    <duration>01:36</duration>
  </track>
  <track>
    <position>7</position>
    <title>Bikini Babe Workout</title>
    <duration>03:25</duration>
  </track>
  <track>
    <position>8</position>
    <title>IHOP</title>
    <duration>01:41</duration>
  </track>
  <track>
    <position>9</position>
    <title>IHOP Parking Lot</title>
    <duration>02:33</duration>
  </track>
  <track>
    <position>10</position>
    <title>Feed the Beast</title>
    <duration>02:20</duration>
  </track>
  <track>
    <position>11</position>
    <title>Daddy</title>
    <duration>02:33</duration>
  </track>
  <artistdesc>The Lonely Island is an American comedy trio, formed by Akiva Schaffer, Andy Samberg, and Jorma Taccone in Berkeley, California in 2001. They have written for and been featured in the American TV program Saturday Night Live (SNL).
The three first met in junior high. After graduating from college, they regrouped and moved to Los Angeles, where they struggled to find work and began making short films, combining absurdist comedy and occasionally music. Among the first performers to post their material on the Internet, they involved themselves with Channel 101, a non-profit monthly short film festival. Their popularity at the screenings led to unsuccessful pilot deals with Fox and Comedy Central and a writing job for the 2005 MTV Movie Awards. That show's host, Jimmy Fallon, recommended them to Lorne Michaels, the creator of Saturday Night Live.
The group was hired for SNL in 2005, with all three as writers and Samberg as a featured player. Bypassing the traditional process of pitching, they recorded their own material independently and submitted it to the program. Their second sketch to air, "Lazy Sunday", became an internet sensation, the first of many viral videos they produced while at SNL. They led their own division at the program — SNL Digital Shorts — which led to numerous viral videos, including "Motherlover", "Dick in a Box", "Jizz in My Pants", "I'm on a Boat", "Like a Boss", "I Just Had Sex", "Jack Sparrow", and "YOLO". Their musical comedic work has comprised four full studio albums: Incredibad (2009), Turtleneck &amp; Chain (2011), The Wack Album (2013), and The Unauthorized Bash Brothers Experience (2019), along with a soundtrack album for their 2016 film Popstar: Never Stop Never Stopping. The three retired from SNL in the early 2010s, but occasionally make guest appearances.
The troupe has written, directed and starred in two feature-length films, Hot Rod, released in 2007, and Popstar: Never Stop Never Stopping, co-produced by Judd Apatow and released in 2016. The group also produced the 2020 film Palm Springs, starring Samberg and Cristin Milioti.

</artistdesc>
  <label />
</album>
derkington commented 3 years ago

I am experiencing the same bug, I logged in just now report this exact issue.

JoLander commented 3 years ago

I'm facing the same issue. I have organized my albums and my compilations in two media libraries. When I go to the albums -> 'album artists' and select one artist for which I have only one album, this album is shown along with all compilations which this artist has contributed to. Sometimes I see one 'real' album and about ten compilations. All sorted by alphabet. In the compilations I set the 'album artist' always to 'various'. Nevertheless, the compilation is found as it seems that the artist is selected instead of the 'album artist'.

emaen commented 3 years ago

Jellyfin 10.7.5 Windows 7

I am experiencing the same bug. I logged in to report this exact same issue.

Artist credited for just one song in others artists albums, see these albums assigned to him Example : Johnny Cash sang, as a guest, on derek & domino's album and on U2 'zooropa' album. These albums are also assign to Johnny Cash as if they were his albums!!

Tested a little bit and seem that jellyfin mixing up "artist" and "albumartist".

jellyfin bug artist jellyfin bug artist 2

telans commented 3 years ago

This seems like it may be a jellyfin-web issue, as I don't see extra albums with jellfin-vue

JoLander commented 3 years ago

This seems like it may be a jellyfin-web issue, as I don't see extra albums with jellfin-vue

You are right. I tested the jellyfin-vue interface and the albums of an artist are correctly separated from compilations where the artist appears as well.

ghost commented 3 years ago

This seems like it may be a jellyfin-web issue, as I don't see extra albums with jellfin-vue

You are right. I tested the jellyfin-vue interface and the albums of an artist are correctly separated from compilations where the artist appears as well.

Does that mean i need to move this issue to the jellyfin-web repository ?

JoLander commented 3 years ago

This seems like it may be a jellyfin-web issue, as I don't see extra albums with jellfin-vue

You are right. I tested the jellyfin-vue interface and the albums of an artist are correctly separated from compilations where the artist appears as well.

Does that mean i need to move this issue to the jellyfin-web repository ?

Probably yes, but what's about the Android app? The mentioned problem appears in a standard web browser and in the Android jellyfin app, but not in jellyfin-vue. Does the Android app uses jellyfin-web for the data retrieval ? If not, then we have this issue in jellyfin-android as well.

telans commented 3 years ago

I see it in Gelli too. cc @dkanada

omniusaspirer commented 3 years ago

Adding to this- this behavior is definitely new to jellyfin-web and is a serious breaking change for music functionality. Some artists have literally dozens of albums listed now which is impossible to navigate reasonably. I created an issue report for Gelli over a year ago which @dkanada recently acknowledged an intention to fix when he's able.