search

jellyfin / jellyfin-web

Web Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.33k stars 1.24k forks source link

Enabling HTTPS requires restart - doesn't notify user #2791

Open gbakeman opened 3 years ago

gbakeman commented 3 years ago

Describe the bug When I enabled HTTPS and added the certificate, I clicked save but was unable to access Jellyfin on the HTTPS port. I also confirmed that it was not listening on that port on the host. When I checked the logs, I saw a couple of lines:

[2021-07-14 22:37:06.462 +00:00] [INF] [78] Emby.Server.Implementations.ApplicationHost: App needs to be restarted due to configuration change.
[2021-07-14 22:37:06.473 +00:00] [INF] [78] Emby.Server.Implementations.ApplicationHost: App needs to be restarted.

The context they were in didn't tell me why I needed to reboot, but I restarted the docker container anyways and sure enough, the HTTPS port was listening.

System (please complete the following information):

To Reproduce

  1. Start with new config
  2. Supply certificate file
  3. Enable HTTPS
  4. HTTPS is not accessible, and no notification is given to the user to perform any additional actions (restart)

Expected behavior Any one of the following:

  1. The network system is hot-restarted to minimize disruption and enable listening on the HTTPS port
  2. Jellyfin prompts the user to restart, and does so upon confirmation
  3. Jellyfin notifies that the user must restart for changes to take effect

Server Logs

[2021-07-14 22:37:06.457 +00:00] [INF] [78] Jellyfin.Networking.Manager.NetworkManager: Defined LAN addresses : "[::1/128,fc00::/7,fe80::/10,127.0.0.1/8,10.0.0.0/8,172.16.0.0/12,192.168.0.0/16]"
[2021-07-14 22:37:06.458 +00:00] [INF] [78] Jellyfin.Networking.Manager.NetworkManager: Defined LAN exclusions : "[]"
[2021-07-14 22:37:06.459 +00:00] [INF] [78] Jellyfin.Networking.Manager.NetworkManager: Using LAN addresses: "[::1/128,fc00::/7,fe80::/10,127.0.0.1/8,10.0.0.0/8,172.16.0.0/12,192.168.0.0/16]"
[2021-07-14 22:37:06.460 +00:00] [INF] [78] Jellyfin.Networking.Manager.NetworkManager: Using bind addresses: "[]"
[2021-07-14 22:37:06.461 +00:00] [INF] [78] Jellyfin.Networking.Manager.NetworkManager: Using bind exclusions: "[]"
[2021-07-14 22:37:06.462 +00:00] [INF] [78] Emby.Server.Implementations.ApplicationHost: App needs to be restarted due to configuration change.
[2021-07-14 22:37:06.473 +00:00] [INF] [78] Emby.Server.Implementations.ApplicationHost: App needs to be restarted.
[2021-07-14 22:37:06.588 +00:00] [WRN] [78] Jellyfin.Server.Middleware.ResponseTimeMiddleware: Slow HTTP Response from "http://host:8096/System/Configuration/network" to "192.168.0.10" in 0:00:01.2336518 with Status Code 204
[2021-07-14 22:37:13.640 +00:00] [INF] [63] Emby.Server.Implementations.HttpServer.WebSocketManager: WS "192.168.0.10" closed
[2021-07-14 22:37:31.727 +00:00] [INF] [16] Emby.Server.Implementations.HttpServer.WebSocketManager: WS "192.168.0.10" request
[2021-07-14 22:37:32.180 +00:00] [WRN] [32] Jellyfin.Server.Middleware.ResponseTimeMiddleware: Slow HTTP Response from "http://host:8096/Users/559557b55f3c43648b4f9021fe2f5dc4" to "192.168.0.10" in 0:00:00.501593 with Status Code 200
jellyfin-bot commented 2 years ago

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

gbakeman commented 2 years ago

I'm assuming this is still an issue?