search

jellyfin / jellyfin-web

Web Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.28k stars 1.21k forks source link

theme song / theme videos volume adjustments #3086

Open throwabird opened 2 years ago

throwabird commented 2 years ago

Currently when a theme song is playing in the background you have no way to control the volume it is playing at. When using Syncplay a Playback Control Bar appears and you can pause, play, skip and adjust the volume as described in #2918 and #3059.

I think it would be worth having an option to always display the Playback Control Bar when the theme song / theme video is playing especially since https://github.com/jellyfin/jellyfin/issues/537 is not yet implemented and it is not uncommon for different theme songs to have completely different volumes. Alternatively a less noticeable / intrusive volume control such as the one during video playback when using the arrow keys (just display when adjustments are made) could be considered.

I am hoping to get some different opinions on this topic.

dmitrylyzo commented 2 years ago

https://github.com/jellyfin/jellyfin-web/pull/2028#issuecomment-721312845 I just thought. If we hide nowPlayingBar, we cannot change volume (other controls are less usable for theme song). Keyboard media buttons (volume-related) can be handled in scripts/keyboardNavigation.js. TVs (real ones) have a physical volume control - no problem. But what about mouse users?

As an additional idea, we could add volume option next to the theme-related checkboxes in Display user settings - just like Music volume in games. Then use it to suppress theme songs volume.

In addition, the plan was to add key bindings on the Controls page in the user settings (#2532). Probably for each state: browsing, playback. No one is currently implementing this feature.

adripo commented 4 months ago

Hello, is there any plan to address this feature request in the near future?