search

jellyfin / jellyfin-web

Web Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.38k stars 1.27k forks source link

Last subtitle line dont show up #3326

Closed EduFdezSoy closed 2 years ago

EduFdezSoy commented 4 years ago

The last line of the subtitles is not showing, only the last line.

Tested in:

The files tested are all mkv with ass subtitles inside

I checked the subtitles but cant see anything wrong inside, here is the last line:
Dialogue: 0,0:10:25.58,0:10:29.17,Italics,Honda,0000,0000,0000,,That is the task of a comic bookstore.

System:

stale[bot] commented 3 years ago

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments. If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or nightlies, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label. This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

avi-grtl commented 3 years ago

I'm having this same issue with .mkv and .ass subtitles dropping the last line of the subtitle from playback. Last line confirmed working in another player.

Changing Burn Subtitles from Auto to All Complex formats works around this, but causes transcoding to occur when otherwise it wouldn't need to.

SightSpirit commented 3 years ago

Can confirm this problem on ExoPlayer, as well. Running 10.7.5 on Windows 10; client is official app 2.2.3 (Google Play build) running on Pixel 2 XL with Android 11. Affected subtitles are in VODSUB format.

stale[bot] commented 3 years ago

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments. If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or nightlies, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label. This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

jjhhgg100123 commented 3 years ago

Also experiencing this on Jellyfin 10.7.7 running on Ubuntu. I also have issues with the subtitles disappearing if I skip in the middle of a line, that may be unrelated though.

Tested both direct play and transcoded, on Firefox 95.0b2, and Chrome 95.0.4638, on the latest W10.

File is H264, AAC, SSA subtitles. Plays normally in VLC outside of Jellyfin.

Shados commented 2 years ago

Yeah, I'm getting this issue as well. The last subtitle shows up fine if I use mpv or vlc to play the file directly, but Jellyfin fails to display it. Given it's precisely the last line, kinda makes me wonder if it's an off-by-1 error somewhere :V.

nielsvanvelzen commented 2 years ago

Moved to jellyfin-web. Issue is probably caused by the JavascriptSubtitlesOctopus library.

dmitrylyzo commented 2 years ago

Issue is probably caused by the JavascriptSubtitlesOctopus library.

Yes, this can be fixed with https://github.com/jellyfin/JavascriptSubtitlesOctopus/pull/21 There is a better fix for tag parser in the upstream, but that PR has stalled.

Feynt commented 2 years ago

Reporting in, can confirm this is still an ongoing issue. Inserting an extra garbage line into subtitles will allow me to read the final proper line in the videos.

dmitrylyzo commented 2 years ago

Fixed by #3644