Chromecast connection in UI is lost when switching pages

cvium commented 5 years ago

Expectation

Sender (app, server dashboard etc.) should be aware of its connection to Chromecast even after page reload.

It should be able to reconnect to an on-going casting session.

Reality

Refreshing the page or even going to the server dashboard causes the connection to be lost and cannot be regained by connecting again.

It still continues to stream, but the sender can no longer control it.

Steps to reproduce

Connect to CC via Chrome
Start a stream and make sure remote controls show up in Chrome
Go to server dashboard
CC icon is no longer active and re-connecting to CC has no effect. 4a. NOTE: Chrome tab is still connected to CC.

Comments

cvium commented 5 years ago

Hmm, this appears to be working ?? Can you test it @anthonylavado ?

anthonylavado commented 5 years ago

Will test again

anthonylavado commented 5 years ago

@cvium - Just tested, still happening to me with Chrome Version 71.0.3578.98 (Official Build) (64-bit), macOS 10.14.2.

Edit: Now it's working. What the heck?! Edit 2: It just broke again. I don't understand this.

stale[bot] commented 5 years ago

Issues go stale after 60d of inactivity. Mark the issue as fresh by adding a comment or commit. Stale issues close after an additional 7d of inactivity. If this issue is safe to close now please do so. If you have any questions you can reach us on Matrix or Social Media.

JustSch commented 4 years ago

this issues still occurs on win 10 1903 Chrome Version 80.0.3987.87 (Official Build) (64-bit) @anthonylavado

hamburglar2160 commented 4 years ago

This should be fixed with the new CAF receiver.

JustSch commented 4 years ago

is that part of the nightly release or has it not been pushed to chromecasts themselves yet? I tested it just now and still lost chromecast controls when going to dashboard jellyfin 10.5.0 Chrome version 83.0.4103.61 (Official Build) (64-bit) Win 10 1903

hamburglar2160 commented 4 years ago

It's not available quite yet, but should be in 10.6 under the form of the 'nightly' Chromecast client when that gets built.

heyhippari commented 4 years ago

I don't think the new receiver app will change anything for this particular issue.

I see two issues with our current ChromecastPlayer (the sender part of the app):

It uses the Base API instead of the Framework API. The Base API is lower-level than the Framework API and Google recommends using this last one when building a Sender app.
During the bootstrap process for the app, we never check for an existing Cast session. So the session still exists, but it's never picked up by the ChromecastPlayer.

The first point will require a rewrite of the ChromecastPlayer. The second point will require some changes to the web client itself, but I'm unsure of the scope of these changes at the moment.

brianjmurrell commented 3 years ago

I don't think it even takes a page refresh or switching away to anywhere. I can start casting leaving the browser on the show being cast and come back and the casting connection is gone with no ability to control the casting stream. Trying to re-connect to the casting device ends the stream being casted.

brianjmurrell commented 3 years ago

This, frankly, seems much worse on the most recent release, 10.7.5.

Honestly, it makes using Jellyfin on anything other than a computer or phone quite useless. I'm not sure about anyone else, but the idea of being able to watch the 42 or so minutes of a 60 minute program without a stop, pause, rewind, etc. is quite impossible. Even trying to restart a stream and getting it play to where you left off -- once you have managed to get it to stop playing on a Chromecast device -- itself is even quite frustrating.

Are most people really using JF on computers and phones without Chromecast? This just feels like a significant regression in the general usability of JF. :-(

brianjmurrell commented 3 years ago

Hrm. So the remote control functionality seems to work much better from a Linux Chrome browser than it does from Chrome on an Android phone. Having to drag my laptop out to the livingroom, rather than just using my phone is still pretty low usability.

PrplHaz4 commented 3 years ago

Are most people really using JF on computers and phones without Chromecast? This just feels like a significant regression in the general usability of JF. :-(

FireTV and DLNA have been a pretty good 10ft experience on my end - others are using AppleTV and Kodi successfully...

jellyfin / jellyfin-web