jellyfin / jellyfin-web

Web Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.28k stars 1.22k forks source link

Subtitle offset text field is clamped to slider min/max values #3783

Open ambroisie opened 2 years ago

ambroisie commented 2 years ago

Describe The Bug

Currently, when one tries to have an offset greater than 30 seconds in either directions, the text field "helpfully" resets it to +/-30 seconds because those are the bounds of the slider.

Steps To Reproduce

  1. Open a video with subtitles.
  2. Use Subtitle Offset.
  3. Write a value outside of [-30, 30] in the text entry field.
  4. Press enter to have it be taken into account by the player.
  5. Watch your value be overwritten automatically.

Expected Behavior

If a user enters a value by hand, I would expect the software to respect it, instead of trying to keep it synchronized with the slider which is decidedly not big enough for the value I want to enter.

I think it would make sense that it keeps the value I enter, moves the slider to try and reflect that value: if it is outside of the slider range, just show it clamped at either end. If the user interacts with the slider later on, then synchronize the text field as usual.

Screenshots

Trying to enter a 45s offset ![image](https://user-images.githubusercontent.com/12465195/181924726-1fb0f1f2-24ea-4f94-8759-676be52a8f23.png)
Offset is reset to 30s ![image](https://user-images.githubusercontent.com/12465195/181924735-13e99131-242a-4b14-9ba6-0fbcd09108f4.png)

System (please complete the following information):

jellyfin-bot commented 1 year ago

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

ambroisie commented 1 year ago

This is still an issue.

jellyfin-bot commented 1 year ago

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

ambroisie commented 1 year ago

This is still relevant to me.

iChristGit commented 3 months ago

Upping this as its an issue for some of me as well.

SrGesus commented 2 months ago

This is a real annoying issue