search

jellyfin / jellyfin-web

Web Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.28k stars 1.21k forks source link

Volume slider initially not marked as blue when starting music playback #4011

Open Shadowghost opened 1 year ago

Shadowghost commented 1 year ago

Describe The Bug The volume slider initially isn't marked as blue up until the marker when starting music playback. Works fine on the video player though.

Steps To Reproduce

  1. Start playing music
  2. Look at the volume slider

Expected Behavior Slider being blue up to the marker.

Screenshots grafik

System (please complete the following information):

dmitrylyzo commented 1 year ago

https://github.com/jellyfin/jellyfin-web/blob/a77b003817d5c5fc50957d6151497cefdfb9e71f/src/components/nowPlayingBar/nowPlayingBar.js#L430 is executed before the slider becomes an emby-slider, so the valueset event is ignored.

Dirty fix:

setTimeout(() => {
    if (!volumeSlider.dragging) {
        volumeSlider.value = volumeLevel || 0;
    }
}, 0);

btw, Chrome 79 works fine, probably because it has older webcomponents.