jellyfin / jellyfin-web

Web Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.17k stars 1.15k forks source link

Shuffling music with pagination on only shuffles from the current page, not all songs #4933

Open q5BWr6gN opened 8 months ago

q5BWr6gN commented 8 months ago

Describe The Bug

With pagination on and selecting the "Songs" section of the music library, shuffling only draws from the current page, and not all songs available in that folder.

Steps To Reproduce

  1. Go to your music library with pagination on, and have enough items in your library to create multiple pages
  2. Click on any item to begin playback
  3. Click on shuffle and repeat on the playback bar
  4. Click the next song button
  5. Observe that only music from the current page is used for shuffle (a large library sorted by A-Z will only show songs from the beginning of the alphabetical order).

Expected Behavior

Shuffling from the song section, regardless of the current page, should shuffle from all songs in the music library and not just from the current page.

Logs

None produced.

Screenshots

image

System (please complete the following information):

Additional Context

dmitrylyzo commented 8 months ago

Shuffle on the "Now playing" bar is for shuffling the current play queue.

In the next release there will be a Shuffle for library (https://github.com/jellyfin/jellyfin-web/pull/3741). But it still won't play the entire library - it takes 300 random songs.

rmackinnon commented 4 months ago

From what I've observed, if I enqueue on the android TV app, it limits the queue to approximately 180 songs, and doesn't seem to shuffle the tracks.

UX wise, if a user chooses to enqueue a playlist of an entire collection (for my example 872 tracks), and selects shuffle they would expect it to shuffle the whole playlist. Whereas if the list is over a certain size, we should probably notify the user the shuffle on the queue is limited to 300 items. What kind of bottle neck is there that is limiting large scale shuffling?

In my use case, where I have a large collection, I'm looking to shuffle my entire Verve Master's collection. While I love me some Chic Corea, hearing him (and the same artist tracks) everytime I shuffle the collection isn't always so great.

jellyfin-bot commented 1 week ago

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.