search

jellyfin / jellyfin-web

Web Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.27k stars 1.2k forks source link

Track gets skiped after closing a book #5288

Open lomenzel opened 5 months ago

lomenzel commented 5 months ago

Describe The Bug If listening to music while reading a book, when closing the book the current treck ends and a new one is started

Steps To Reproduce Start a music song Open a Book Close the Book see that next song is started

Expected Behavior I would expect the song to finish before the next one is played

Logs

System (please complete the following information):

Additional Context

scottross123 commented 5 months ago

Hey, I was able to recreate this bug, same version and on Linux. I think I have a fix and made a PR, it seems be due this line of code : Events.trigger(this, 'stopped', [stopInfo]); in src/plugins/bookPlayer/plugin.js. https://github.com/jellyfin/jellyfin-web/blob/fce1e7f173e38c499b3fc98f5f50413a12e29592/src/plugins/bookPlayer/plugin.js#L68

https://github.com/jellyfin/jellyfin-web/blob/fce1e7f173e38c499b3fc98f5f50413a12e29592/src/plugins/bookPlayer/plugin.js#L64C9-L69C1

This code seems to dispatch an event which causes the media player to stop and go to the next track, and is not related to the actual closing of the book. Removing it fixes the issue and does not affect the open/closing of books.

I am a new contributor to Jellyfin though so I would first like a more senior contributor or just someone more familiar with the code base to confirm this.

5329

thornbill commented 4 months ago

Copied from the PR:

This is currently working as intended. As far as I know the stopped event is needed for playback tracking. The playback manager would need a major overhaul to support playing multiple things at once in the same session.

jellyfin-bot commented 2 days ago

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.