jellyfin / jellyfin-web

Web Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.41k stars 1.28k forks source link

Gamepad not working in browser #5445

Closed ihatetoregister closed 2 months ago

ihatetoregister commented 6 months ago

Describe The Bug

I want to navigate the jellyfin web UI with gamepad.

Steps To Reproduce

  1. Connect game controller
  2. Load the jellyfish web UI in brower (tested wit Safari and Firefox)
  3. Try navigate UI with game controller

Expected Behavior

Navigate UI with game controller

Logs

Can be provided on request

Screenshots

System (please complete the following information):

Additional Context

Trying to figure out why it does not work as the feature is supposed to implemented:

https://github.com/jellyfin/jellyfin-web/blob/1711664e51e8908ad148f719036cc24ac539fdfb/src/scripts/settings/appSettings.js#L27 https://github.com/jellyfin/jellyfin-web/blob/1711664e51e8908ad148f719036cc24ac539fdfb/src/scripts/gamepadtokey.js#L88 https://github.com/jellyfin/jellyfin-web/blob/1711664e51e8908ad148f719036cc24ac539fdfb/src/scripts/keyboardNavigation.js#L200

Could not find the setting mentioned, maybe I'm just blind. I just have a feeling this is not implemented in the server itself, but in the desktop app layer? Could someone confirm this?

Game pad is working fine with Xbox Cloud Gaming and this test page: https://gamepadtester.net/

Related https://github.com/jellyfin/jellyfin-web/issues/5016

ihatetoregister commented 6 months ago

Ok, after a few hours of fiddling it seem to work, it's just very well hidden. For future reference, here is how to enable it:

  1. Setting -> Display -> Display mode: TV
  2. Reload
  3. Settings -> Controller -> Enable gamepad
  4. Reload

Could we enable this by default maybe?

dmitrylyzo commented 6 months ago

Could we enable this by default maybe?

No. TV mode is designed for TVs. It lacks some features that Desktop and Mobile have. For example, there's no Dashboard. So it is up to the user to enable the TV mode.

In case you are using Jellyfin Media Player: AFAIK, you can run it with the "tv" option (not sure what it's called), then TV mode will be selected automatically.

FYI, keyboard (gamepad) navigation is only available in TV mode, as there is no focus indicator in Desktop and Mobile.

jellyfin-bot commented 2 months ago

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.