search

jellyfin / jellyfin-web

Web Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.39k stars 1.27k forks source link

Trickplay cannot be turned on or off on mixed libraries #5490

Closed BobHasNoSoul closed 4 months ago

BobHasNoSoul commented 6 months ago

Describe The Bug people say you can enable trickplay in each library however there is no option for it once the library has been created, this gives you no option to turn it on for the older librarys that were already made.

Steps To Reproduce

  1. Go to '/web/index.html#/dashboard/libraries'
  2. Click on 'the ... for the library that you want to enable trickplay for'
  3. Click on 'manage library'
  4. Scroll down and look for the trickplay option there isnt one

Expected Behavior for it to have a way to turn it off or on for existing libraries without the need to delete the library and rescan it when deciding to turn trickplay off or on.

Logs there are no relevant logs

Screenshots no applicable screenshots

System (please complete the following information):

Additional Context pretty sure its a bug or an oversight.. sorry if it isnt and im just using it wrong.

BobHasNoSoul commented 6 months ago

temporary workaround is to manually edit the chunk.js (seems to be different for me and my docker build so im not sure the naming standard but it is this on my normal install 95454.d1b2509d245890e33deb.chunk.js) to add this

<div class="trickplaySettingsSection hide"> <h2>${Trickplay}</h2> <div class="checkboxContainer checkboxContainer-withDescription fldExtractTrickplayImages"> <label> <input type="checkbox" is="emby-checkbox" class="chkExtractTrickplayImages"/> <span>${OptionExtractTrickplayImage}</span> </label> <div class="fieldDescription checkboxFieldDescription">${ExtractTrickplayImagesHelp}</div> </div> <div class="checkboxContainer checkboxContainer-withDescription fldExtractTrickplayDuringLibraryScan advanced"> <label> <input type="checkbox" is="emby-checkbox" class="chkExtractTrickplayDuringLibraryScan"/> <span>${LabelExtractTrickplayDuringLibraryScan}</span> </label> <div class="fieldDescription checkboxFieldDescription">${LabelExtractTrickplayDuringLibraryScanHelp}</div> </div> </div>

inside the the html section that works and gives it the ability to be enabled on preexisting libraries without the need to delete and rescan the full libraries some users already have.

note: to find the exact chunk to edit you need to use network tab after opening the admin page for libraries inside of your firefox or chrome browser, then open the manage libraries page and the chunk should be inside the network tab with another one you are looking for the library settings page.

ferferga commented 6 months ago

Is your web client also in 10.9?

BobHasNoSoul commented 6 months ago

It is the 10.9.0 webclient from the deb file provided for jellyfin-web from the Ubuntu sudo apt install jellyfin-web

The admin page has updated to 10.9.0 also just has this one bug for me but the edit in my previous post fixes this issue

On Mon, 13 May 2024, 11:03 Fernando Fernández, @.***> wrote:

Is your web client also in 10.9?

— Reply to this email directly, view it on GitHub https://github.com/jellyfin/jellyfin-web/issues/5490#issuecomment-2107158024, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFPTXLAIA5TL4WLYEO4REY3ZCCFV7AVCNFSM6AAAAABHTYP676VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBXGE2TQMBSGQ . You are receiving this because you authored the thread.Message ID: @.***>

nicknsy commented 6 months ago

This is likely related to https://github.com/jellyfin/jellyfin/issues/11284 if your library types are set to mixed movies & tv shows.

anujsedhai commented 5 months ago

i'm also facing the same issue. Jellyfin version: 10.9.2 (Docker installation) Docker base image: linuxserver/jellyfin

Patryk122PL commented 5 months ago

Same issue Docker image: jellyfin/jellyfin:10.9.4.

Trickplay settings are visible while configuring new mixed type library, but after saving it, it's no longer there. Confirmed on multiple browsers and with cache removed.

Xeddius commented 4 months ago

Updated Jellyfin, enabled Trickplay, no option visible for any existing library. Bug still exists in 10.9.7 of Jellyfin docker image.

sethro2 commented 4 months ago

I just upgrade to v10.9.7 of the Windows installer and seeing the same issue. Trickplay could be toggled on a "movies" library however not for the libraries listed as "other" which contain tv shows and personal videos.