jellyfin / jellyfin-web

Web Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.33k stars 1.24k forks source link

[Issue]: Cannot edit metadata or images of owned playlist as an unprivileged user. #5641

Open reacocard opened 4 months ago

reacocard commented 4 months ago

Please describe your bug

Playlists can now be per-user which is great, but if a user doesn't have permissions to manage the server they cannot edit their own playlist's metadata, such as the title and cover image.

This is how the menu looks on an unprivileged user - there is no "Edit Metadata" or "Edit Images" option: image

And further, since admins cannot see private user playlists, there is no way for them to edit the metadata on the users' behalf either, so there is no way to edit this metadata at all.

Users should have the ability to edit metadata and images for the playlists they own, regardless of whether they have the ability to manage the whole server.

Reproduction Steps

  1. Create a Music library
  2. Create a user who does not have permission to manage the server, but has access to the Music library
  3. As that user, create a playlist containing whatever songs you like.
  4. As that user, open the "..." menu on the playlist. Note the lack of options to edit metadata and images.

Jellyfin Version

10.9.0

if other:

No response

Environment

- OS: Debian 12
- Linux Kernel: Debian 6.4.4-3~bpo12+1
- Virtualization: None
- Clients: Web
- Browser: Firefox 126
- FFmpeg Version: not applicable
- Playback Method: not applicable
- Hardware Acceleration: not applicable
- GPU Model: not applicable
- Plugins: not applicable
- Reverse Proxy: nginx
- Base URL: none
- Networking: host
- Storage: local

Jellyfin logs

not applicable

FFmpeg logs

No response

Please attach any browser or client logs here

No response

Please attach any screenshots here

No response

Code of Conduct

nylimited commented 4 months ago

Why on earth would I want a non-admin user to edit metadata?? They can create a playlist containing tracks/songs, they can add to their list, they can remove things from their lists. I certainly do not want them to edit metadata or images or anything like that! This is not unlike any other service - Amazon, Netflix, whatever - where you can make a playlist but definitely cannot change descriptions. Seriously!

reacocard commented 4 months ago

Because it's THEIR playlist - noone else on the server can manage it if it's not public, and if it doesn't affect anyone else why shouldn't they be able to edit it?

Certainly, unprivileged users should not be able to edit playlists owned by the system or by other users, but editing their own, private playlists absolutely should be possible.

nylimited commented 4 months ago

Metadata is specific to media (e.g. an album), not to a person or a playlist. If they change it, they would do so for everyone.

reacocard commented 4 months ago

I'm not talking about the metadata of individual tracks or albums, i'm talking about the metadata of the playlist itself - the stuff you can edit as an admin in the "..." menu on a playlist, like so:

image image

nylimited commented 4 months ago

I'm still not convinced it is needed but you are right - that is safe for them to play with. 👍

jellyfin-bot commented 1 week ago

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.