search

jellyfin / jellyfin-web

Web Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.4k stars 1.28k forks source link

Stuck page titles on admin Dashboard #5686

Closed BotBlake closed 4 months ago

BotBlake commented 5 months ago

Describe The Bug

The html page titles in the Admin Dashboard arent changing everywhere. e.g. the DLNA Page sets it. If you go back to the "Home" admin Dashboard, the Page title still says "DLNA".

This happens for: DLNA, Notifications and Activity

Steps To Reproduce

  1. Go to the Admin Dashboard (through Jellyfin Web)
  2. Click on DLNA (or Notifications / Activity)
  3. See the Page title that matches the Tab you opened
  4. Click on any Tab that isnt DLNA, Notifications or Activity
  5. See the Page title still being the one from the previous page. --> This title only changes on theese three pages

Expected Behavior

The Title should reset when switching to another page,

Logs

Screenshots

grafik

System (please complete the following information):

Additional Context

thornbill commented 5 months ago

It seems there was some magic in the old drawer that would update the title when you clicked a link... https://github.com/jellyfin/jellyfin-web/blob/1d647bcf037d46ca13028824d0c5c2dfb5ae6e1b/src/scripts/libraryMenu.js#L387

venkat-karasani commented 4 months ago

identified the root cause, will fix and create a PR.