Pressing 'reset password' with empty password field throws exception

krestenlaust commented 3 weeks ago

This issue respects the following points:

[X] This is a bug, not a question or a configuration issue; Please visit our forum or chat rooms first to troubleshoot with volunteers, before creating a report. The links can be found here.
[X] This issue is not already reported on GitHub (I've searched it).
[X] I'm using an up to date version of Jellyfin Server stable, unstable or master; We generally do not support previous older versions. If possible, please update to the latest version before opening an issue.
[X] I agree to follow Jellyfin's Code of Conduct.
[X] This report addresses only a single issue; If you encounter multiple issues, kindly create separate reports for each one.

Description of the bug

There's a log.

I'm just realizing now that this might be the wrong repo, can this be moved to the right one?

Reproduction steps

Pressing 'nulstil adgangskode' ('reset password') in this state, causes the program to buffer

What is the current bug behavior?

To the user, it appears to hang, when a popup for new password was expected.

What is the expected correct behavior?

Either do data validation before pressing the button, or have a popup with the new password. I'm not entirely sure what the expected user journey is here.

Jellyfin Server version

10.9.9+

Specify commit id

No response

Specify unstable release number

No response

Specify version number

No response

Specify the build version

10.9.10

Environment

- OS: Debian GNU/Linux 12 (bookworm)
- Linux Kernel: 6.6.31+rpt-rpi-v8
- Virtualization: none
- Browser:
- FFmpeg Version:
- Playback Method:
- Hardware Acceleration:
- GPU Model:
- Plugins:
- Reverse Proxy:
- Base URL:
- Networking:
- Storage:

Jellyfin logs

Sep 01 09:19:29 raspberrypi jellyfin[884]: [09:19:29] [INF] WS 192.168.50.201 closed
Sep 01 09:19:30 raspberrypi jellyfin[884]: [09:19:30] [INF] WS 192.168.50.201 request
Sep 01 09:19:35 raspberrypi jellyfin[884]: [09:19:35] [ERR] Error processing request. URL POST /Users/f61a4c5d910749a4b95e27a4c128e794/Password.
Sep 01 09:19:35 raspberrypi jellyfin[884]: System.ArgumentException: Admin user passwords must not be empty (Parameter 'newPassword')
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Jellyfin.Server.Implementations.Users.UserManager.ChangePassword(User user, String newPassword)
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Jellyfin.Api.Controllers.UserController.UpdateUserPassword(Nullable`1 userId, UpdateUserPassword request)
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at lambda_method1034(Closure, Object)
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor.TaskOfActionResultExecutor.Execute(ActionCont>
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeActionMethodAsync>g__Awaited|12_0(C>
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeNextActionFilterAsync>g__Awaited|10>
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed contex>
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& st>
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeInnerFilterAsync()
Sep 01 09:19:35 raspberrypi jellyfin[884]: --- End of stack trace from previous location ---
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeNextResourceFilter>g__Awaited|25_0(Resource>
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Rethrow(ResourceExecutedContextSealed context)
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boo>
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.InvokeFilterPipelineAsync()
Sep 01 09:19:35 raspberrypi jellyfin[884]: --- End of stack trace from previous location ---
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Awaited|17_0(ResourceInvoker invok>
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Awaited|17_0(ResourceInvoker invok>
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Jellyfin.Api.Middleware.ServerStartupMessageMiddleware.Invoke(HttpContext httpContext, IServerApplicationH>
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Jellyfin.Api.Middleware.WebSocketHandlerMiddleware.Invoke(HttpContext httpContext, IWebSocketManager webSo>
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Jellyfin.Api.Middleware.IPBasedAccessValidationMiddleware.Invoke(HttpContext httpContext, INetworkManager >
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Jellyfin.Api.Middleware.LanFilteringMiddleware.Invoke(HttpContext httpContext, INetworkManager networkMana>
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Jellyfin.Api.Middleware.QueryStringDecodingMiddleware.Invoke(HttpContext httpContext)
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Swashbuckle.AspNetCore.ReDoc.ReDocMiddleware.Invoke(HttpContext httpContext)
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Swashbuckle.AspNetCore.SwaggerUI.SwaggerUIMiddleware.Invoke(HttpContext httpContext)
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Swashbuckle.AspNetCore.Swagger.SwaggerMiddleware.Invoke(HttpContext httpContext, ISwaggerProvider swaggerP>
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Jellyfin.Api.Middleware.RobotsRedirectionMiddleware.Invoke(HttpContext httpContext)
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Jellyfin.Api.Middleware.LegacyEmbyRouteRewriteMiddleware.Invoke(HttpContext httpContext)
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Microsoft.AspNetCore.ResponseCompression.ResponseCompressionMiddleware.InvokeCore(HttpContext context)
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Jellyfin.Api.Middleware.ResponseTimeMiddleware.Invoke(HttpContext context, IServerConfigurationManager ser>
Sep 01 09:19:35 raspberrypi jellyfin[884]:    at Jellyfin.Api.Middleware.ExceptionMiddleware.Invoke(HttpContext context)



### FFmpeg logs

_No response_

### Client / Browser logs

_No response_

### Relevant screenshots or videos

_No response_

### Additional information

_No response_

danditomaso commented 2 weeks ago

I wasn't able to duplicate this specific issue, but I did see a similar exception being thrown using Jellyfin inside Docker.

krestenlaust commented 2 weeks ago

Hmm, I can try to reproduce it again, to see if it happens still

ScarMaagur commented 2 weeks ago

from my experience this only happens to admin users i removed admin permissions from the user and it worked

jellyfin / jellyfin-web