jellyfin / jellyfin-web

Web Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.38k stars 1.26k forks source link

Jellyfin-web fails to display list of favorites #6069

Closed MechMK1 closed 1 month ago

MechMK1 commented 1 month ago

Describe The Bug When clicking on a list of songs in the favorites tab, an endless spinner appears and a JavaScript error is printed to the console

Steps To Reproduce

  1. Log into Jellyfin Web
  2. Click on Favorites
  3. Click on Songs
  4. An endless spinner appears

Logs The following error appears in the javascript console:

Uncaught (in promise) TypeError: e is null
    e list.ea9e763cb335ac6a57c1.chunk.js:formatted:1813
    promise callback*23416/e/< list.ea9e763cb335ac6a57c1.chunk.js:formatted:1809
    d main.jellyfin.bundle.js:2
    value main.jellyfin.bundle.js:2
    promise callback*value main.jellyfin.bundle.js:2
    f main.jellyfin.bundle.js:2
    s main.jellyfin.bundle.js:2
    s main.jellyfin.bundle.js:2
    a main.jellyfin.bundle.js:2
    promise callback*l main.jellyfin.bundle.js:2
    u main.jellyfin.bundle.js:2
    u main.jellyfin.bundle.js:2
    f main.jellyfin.bundle.js:2
    A main.jellyfin.bundle.js:2
    s main.jellyfin.bundle.js:2
    s main.jellyfin.bundle.js:2
    u main.jellyfin.bundle.js:2
    u main.jellyfin.bundle.js:2
    A main.jellyfin.bundle.js:2
    promise callback*12854/t.A/< main.jellyfin.bundle.js:2
    Fi node_modules.react-dom.bundle.js:2
    unstable_runWithPriority 60232.bundle.js:2
    jl node_modules.react-dom.bundle.js:2
    Mi node_modules.react-dom.bundle.js:2
    Oi node_modules.react-dom.bundle.js:2
    N 60232.bundle.js:2
    onmessage 60232.bundle.js:2
    77699 60232.bundle.js:2
    s runtime.bundle.js:1
    91434 60232.bundle.js:2
    s runtime.bundle.js:1
    76067 node_modules.react-dom.bundle.js:2
    s runtime.bundle.js:1
    78325 node_modules.react-dom.bundle.js:2
    s runtime.bundle.js:1
    67816 main.jellyfin.bundle.js:2
    s runtime.bundle.js:1
    <anonymous> main.jellyfin.bundle.js:2
    O runtime.bundle.js:1
    <anonymous> main.jellyfin.bundle.js:2
    a runtime.bundle.js:1
    <anonymous> main.jellyfin.bundle.js:2
list.ea9e763cb335ac6a57c1.chunk.js:formatted:1813:34
    e list.ea9e763cb335ac6a57c1.chunk.js:formatted:1813
    (Async: promise callback)
    e list.ea9e763cb335ac6a57c1.chunk.js:formatted:1809
    d main.jellyfin.bundle.js:2
    value main.jellyfin.bundle.js:2
    (Async: promise callback)
    value main.jellyfin.bundle.js:2
    f main.jellyfin.bundle.js:2
    s main.jellyfin.bundle.js:2
    s main.jellyfin.bundle.js:2
    a main.jellyfin.bundle.js:2
    (Async: promise callback)
    l main.jellyfin.bundle.js:2
    u main.jellyfin.bundle.js:2
    u main.jellyfin.bundle.js:2
    f main.jellyfin.bundle.js:2
    A main.jellyfin.bundle.js:2
    s main.jellyfin.bundle.js:2
    s main.jellyfin.bundle.js:2
    u main.jellyfin.bundle.js:2
    u main.jellyfin.bundle.js:2
    A main.jellyfin.bundle.js:2
    (Async: promise callback)
    A main.jellyfin.bundle.js:2
    Fi node_modules.react-dom.bundle.js:2
    unstable_runWithPriority 60232.bundle.js:2
    jl node_modules.react-dom.bundle.js:2
    Mi node_modules.react-dom.bundle.js:2
    Oi node_modules.react-dom.bundle.js:2
    N 60232.bundle.js:2
    onmessage 60232.bundle.js:2
    (Async: EventHandlerNonNull)
    77699 60232.bundle.js:2
    s runtime.bundle.js:1
    91434 60232.bundle.js:2
    s runtime.bundle.js:1
    76067 node_modules.react-dom.bundle.js:2
    s runtime.bundle.js:1
    78325 node_modules.react-dom.bundle.js:2
    s runtime.bundle.js:1
    67816 main.jellyfin.bundle.js:2
    s runtime.bundle.js:1
    <anonymous> main.jellyfin.bundle.js:2
    O runtime.bundle.js:1
    <anonymous> main.jellyfin.bundle.js:2
    a runtime.bundle.js:1
    <anonymous> main.jellyfin.bundle.js:2

I believe this references the file src/controller/list.js, specifically line L859. It seems that item is null, although I don't know why that could be.

Screenshots

Showing a list of favorites works:

image

But when clicking on "Songs", it ends in an endless spinner:

image

Here is the relevant bit of source code in the debugger:

image

System (please complete the following information):

Additional Context Bug appeared recently, so either 10.9.10 or 10.9.9 were good.

MechMK1 commented 1 month ago

Sounds good. I'll close this bug when 10.9.12 is out and I can confirm it fixed.

MechMK1 commented 1 month ago

I hotpatched my existing deployment by modifying the minified .js file and it works fine now.