jellyfin / jellyfin-web

Web Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.42k stars 1.29k forks source link

[bug] Unintentional wrap of button label for "SaveChanges" (multiple languages) #6211

Open bluemoehre opened 1 month ago

bluemoehre commented 1 month ago

Describe The Bug

The label of the save button breaks into multiple lines. This unnecessarily affects the layout and wastes space on mobile screens. It happens with several languages if the label has multiple words and exceeds ~16 chars.

All related project files (59)

(This is an UI/UX issue only - no functional problems detected yet)

Steps To Reproduce

  1. Change UI language to eg. DE | FR | HU | RO
  2. Go to Overview
  3. Open any item's menu
  4. Select Edit Metadata

Expected Behavior

Button label should not break into multiple lines. This can be achieved by using shorter text, enlarging the buttons or allow them to grow.

At least for DE, EN, ES, FR I can say that a single word like "Save" or "Apply" is absolutely common. I am sure it's the same with more languages, so I would recommend updating the translations.

EDIT: I found there is already a short version Save in most languages. I am not sure why this is mixed.

Screenshots

Screenshot

System (please complete the following information):

Additional Context

I've already checked the CSS, and if we prefer changes here, it's also possible. Just a slightly higher risk of breaking something elsewhere.

tylers-username commented 1 month ago

MR: https://github.com/jellyfin/jellyfin-web/pull/6250