jellyfin / jellyfin-web

Web Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
2.41k stars 1.28k forks source link

Add Device Icons for WebOS & Updated Infuse Naming #6281

Open JPKribs opened 3 weeks ago

JPKribs commented 3 weeks ago

Changes First time doing anything on Web so please let me know if this isn't right!

Over in Swiftfin, I added Device Logos and I threw in a webOS (LG TVs) icon as well. I just wanted to add that logo and the logic so Jellyfin-Web had it as well. In my testing, 'LG Smart TV' covers all of the TVs (all 2 I had to test) but I'm unsure if there is a different name for projectors?

I am using webOS's icon from here: https://en.wikipedia.org/wiki/WebOS#/media/File:LG_WebOS_New.svg.

Additionally, during my Swiftfin changes, I found that Infuse doesn't use 'Infuse' as a device name after 7.7(?) and now uses 'Infuse-Direct' or 'Infuse-Library' on later versions. While I was adding WebOS, I added this change as well. I left the original just plain 'Infuse' for anyone running previous versions as well.

Issues https://github.com/jellyfin/jellyfin-web/issues/6280

jellyfin-bot commented 3 weeks ago

Cloudflare Pages deployment

Latest commit bedebd8
Status ✅ Deployed!
Preview URL https://e4ed8fe4.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

viown commented 3 weeks ago

I get this when I try the icon:

image

JPKribs commented 3 weeks ago

I get this when I try the icon:

image

I'm sorry about that! I think I have this resolved. Additionally, while I was looking at my devices I realized Swiftfin wasn't in there on web for Apple either! So I've added both variants of Swiftfin. It looks like 1.0.1 and below is just Jellyfin tvOS/iOS/iPadOS and 1.1+ is Swiftfin tvOS/iOS/iPadOS. Additionally, I put the client name in for LG TV since it looks like we're looking at both client and device.

Let me know if this scaling looks right! I added some items next to it for comparison:

Untitled

JPKribs commented 3 weeks ago

Oh! Lastly, the Samsung.svg should be Samsungtv.svg. I updated that too.

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud