search

jellyfin / jellyfin-webos

WebOS Client for Jellyfin
https://jellyfin.org
Mozilla Public License 2.0
623 stars 60 forks source link

Auto sign out (parental control) #136

Open ChristopherBull opened 1 year ago

ChristopherBull commented 1 year ago

Feature request: In WebOS client, have users automatically sign out, like all other streaming service's client apps.

Description: When using the WebOS client, I cannot find a way to have Jellyfin automatically sign users out after inactivity/etc. Once a user is logged in, they appear to be permanently logged in until manually signed out.

I am not concerned about switching users; I am concerned about young children gaining access to a parent's user account when the parent walks away or in the morning.

I understand the WebOS client is just a wrapper for the web view of the Jellyfin server, so not sure where this could/should be implemented. I would be OK with configuring specific clients with this functionality through the admin dashboard if it cannot be done within the client specifically.

schmitzkr commented 1 year ago

Ah I have this exact same problem/issue. I have been working on a script but I am very new to programming and so I am only making slow progress. I thought the scheduled task plugin for session clean up might work, but this doesnt logout the user and so it isnt quite what I need. I am surprised there is not more traction on this, have you searched for duplicate issues? I found this but it doesn't seem to be quite the same either https://features.jellyfin.org/posts/301/option-to-kill-a-stream-from-a-user

dmitrylyzo commented 1 year ago

The same issue for Tizen: https://github.com/jellyfin/jellyfin-tizen/issues/51

The problem is the credentials stored in localStorage. I tried (this and this) to move them to cookies (sessionStorage doesn't work if "Save Tabs/Session" is enabled in the browser). It seemed to work, but I was not satisfied with the implementation (tbh, I don't remember what exactly).

Scottsum1 commented 11 months ago

Also a problem for me, on Roku and other devices. If I exit out of the app and re-open, it automatically resumes in my profile. So, the parental control functionality is dependent on me remembering to hit "sign out".

I have parental controls set up, I have password and pin enabled on my adult user account. I tried disabling easy sign-in, also set to hide my login from the user list. I've ensured that "remember me" is not checked. None of this matters, if I'm signed in, it stays that way until I hit sign out. It's only a matter of time before I forget to do so and my kid can roam my profile.

The app should prompt for a login at every startup.

schmitzkr commented 11 months ago

I have somewhat been able to resolve this by making sure it does not remember the login, but now my kids ask me to login for them any time they want to see anything. Ideally it would work as other streaming services.

  1. launch jellyfin
  2. show a list of user
  3. select my account and im logged in without entering a password unless i specifically set a password requirement for that account. this way my kids can login without a password to the 'kids' account and the 'dad' account is only accessible with a password.
Scottsum1 commented 11 months ago

3. select my account and im logged in without entering a password unless i specifically set a password requirement for that account. this way my kids can login without a password to the 'kids' account and the 'dad' account is only accessible with a password.

This is already the exact setup I have, my kid's account doesn't have a password while mine does, and I explained above that it does not solve the problem. If you, "dad" are logged in even if you choose not to remember the password, and you forget to log out and simply close the app, when it is re-opened you will still be logged in.

schmitzkr commented 11 months ago

I have easy pin setup, and it doesnt remember me, however I just realized that I can set the easypin to be blank on the kids account, this way they can login without a password (even though there is a password field still, which is a bit confusing)

Scottsum1 commented 11 months ago

I've run out of ways to say this without sounding condescending.
At some point in time, YOU are going to watch something from your account, and you will be a normal human and make the mistake of forgetting to click "log out." When you're done, instead of clicking "log out," you will just click the home button on your Roku. Later, your kids will re-open the Roku app, and it will already be logged in under your "dad" account, and the ywill have access to all the things you insisted they couldn't get to.

schmitzkr commented 11 months ago

Yeah, that sounds pretty annoying, sorry to hear that. I don't know anything about Roku, I thought this issue was for the app in the LG webos app store.

ChristopherBull commented 11 months ago

@Scottsum1 's description is also the same in the WebOS app.

The problem is not about account switching or adding passwords or PINs to accounts (though that UX needs improving), it is about automatically signing you out after inactivity/screen-off.