search

jellyfin / jellyfin-webos

WebOS Client for Jellyfin
https://jellyfin.org
Mozilla Public License 2.0
654 stars 68 forks source link

subtitles bug #267

Open Snipy2k4 opened 2 weeks ago

Snipy2k4 commented 2 weeks ago

Hello,

something has been changed in the last updates. Two years ago I had the problem that ASS subtitles were not displayed in the browser and on my LG OLED. But they did in the desktop app. When I then extracted the subtitles with gMKVExtractGUI and remuxed them with MKVToolNix, it suddenly worked. Then something was changed during an update and the subtitles worked normally. Now files with subtitles created with HandBrake no longer work without extracting the subtitles and recreating the file.

What has happened?

Here is the old post: https://github.com/jellyfin/jellyfin-webos/issues/143 The fix was this: https://github.com/jellyfin/jellyfin/issues/9344 But now it's back?!

Snipy2k4 commented 2 weeks ago

I was able to reproduce this 1:1. If I extract the ASS subtitles and add the subtitles again with MKVToolNix, remove the old ones and create the file again, the subtitles work in the browser and on the LG TV with the app from the LG Store.

It is apparently the same error as the one I linked to.

seeseemelk commented 1 week ago

It broke for me ever since I updated the server to version 10.10

Andreas-76 commented 5 days ago

Don't know if I'm writing in the right place, maybe this should be under jellyfin-ffmpeg. I have the same bug just updated to docker jellyfin 10.10.2 still the same bug. and when it generates the .ass file, it comes with a null character in the file. Image Which means that jellyfin web and android tv app do not display the subtitle but if you remove the null character from the file, it works. To solve this I just made an ugly workaround have created a cron job that goes through the subtitles and removes the null character

* * * * * find /path to/jellyfin/config/data/subtitles/* -maxdepth 1 -type f -name '*.ass' -print0 | xargs -0 -I {} -P 0 sed -i -e 's/\x0//g' {}
Snipy2k4 commented 5 days ago

As I wrote above, the problem is solved by manually extracting the ASS subtitles and adding them without changing them with the MKVTool and recreating the file.

For a large collection, this would mean, in my case, several 10,000 files that would have to be edited manually although it was once fixed and worked. With the update to version 10 this was broken again.

To be honest, I have no desire to edit 10,000+ files manually as there is obviously another way.

If this is the wrong section, I would ask you to move this so that the error can be addressed. Thank you