search

jellyfin / jellyfin-webos

WebOS Client for Jellyfin
https://jellyfin.org
Mozilla Public License 2.0
638 stars 66 forks source link

Add server auto-discovery #33

Closed oddstr13 closed 3 years ago

oddstr13 commented 3 years ago

image

Discovery tested to be working on emulators v1.2.0, v2.0.0, v3.0.0, v4.0.0 & v5.0.0, as well as my v3.something TV

EraYaN commented 3 years ago

I'll go and try this on my TV tonight, and then 🚀 !

EraYaN commented 3 years ago

This seems to work (v4.5 something TV), but it can only discover the IP address, I'd be good if it saved (and connected) using the hostname as well if we expose that anywhere. Since otherwise it only really works in static IP scenarios. I now have another issue while playing that it "crashes" to the login page during playback which is weird, but should be unrelated.

This PR should increase the version number though. (0.3.0 seems in order with this change)

oddstr13 commented 3 years ago

The address is whatever the server responds with, so if you want domain name, that needs to be implemented here;

https://github.com/jellyfin/jellyfin/blob/1894239fee0258af70a4cbaa1f79fdc4a6cb4030/Emby.Server.Implementations/Udp/UdpServer.cs#L50-L52

I have not seen it returning to the login page unless going via the select server option in the menu. Or, if you mean the username/password entry page, then that would be jellyfin-web, not the code in this repo.

Version set to 0.3.0 in both files.

Artiume commented 3 years ago

so would we want to make that configurable like urlOverride https://jellyfin.org/docs/general/administration/configuration.html#main-configuration-options or would it be automatic? i am used to having provide the domain to which the server is discoverable at since the service itself doesnt typically know its domain

EraYaN commented 3 years ago

I have not seen it returning to the login page unless going via the select server option in the menu. Or, if you mean the username/password entry page, then that would be jellyfin-web, not the code in this repo.

I mean the main screen the code in this repo creates. But that is probably a web error, just one that might block us from having it in the store.