search

jellyfin / jellyfin-webos

WebOS Client for Jellyfin
https://jellyfin.org
Mozilla Public License 2.0
638 stars 66 forks source link

Make v1.2.0 #5

Closed EraYaN closed 4 years ago

EraYaN commented 4 years ago

Move three fields into one "baseurl". Add URL validation. Put all CSS at the top of the page.

dkanada commented 4 years ago

@dmitrylyzo thoughts?

dmitrylyzo commented 4 years ago

I can only test in emulator.

If I use BaseURL=/jellyfin and not specify it in the field, I cannot abort connecting. VM75:1 Uncaught SyntaxError: Unexpected token < in JSON at position 0

EraYaN commented 4 years ago

I that makes sense because it will request whatever is at your base domain and that probably sends back an HTML 404 page. It's can't just magically guess your jellyfin baseurl. Although if you enter your full domain in the main field like https://jellyfin.example.com/jellyfin it should work.

dmitrylyzo commented 4 years ago

In my case (http://192.168.2.18:8096), it returns code 200 and ~an empty~ responseText is content of http://192.168.2.18:8096/jellyfin/web/index.html (redirected). 404 error handled normally.

EraYaN commented 4 years ago

Well that depends on what you are also hosting on that server. No idea what your say nginx does, but it's definitely a config problem.

Narfinger commented 4 years ago

On my TV this currently does not show an error if jellyfin is unreachable and just returns to the login screen again without any message.

Narfinger commented 4 years ago

New version fixes my comment from above. Good job!

dkanada commented 4 years ago

@EraYaN I didn't notice that this pull request conflicted with the other one, can you rebase the changes against the new file?

JustAMan commented 4 years ago

I that makes sense because it will request whatever is at your base domain and that probably sends back an HTML 404 page. It's can't just magically guess your jellyfin baseurl. Although if you enter your full domain in the main field like https://jellyfin.example.com/jellyfin it should work.

Sounds more like json parsing errors are unhandled. Also I think there should be a timeout or something preventing this from hanging.