search

jellyfin / jellyfin-webos

WebOS Client for Jellyfin
https://jellyfin.org
Mozilla Public License 2.0
638 stars 65 forks source link

Create a GitHub release #67

Closed Informatic closed 2 years ago

Informatic commented 2 years ago

Hey!

Following @tuxuser's CI release flow work, it would be nice if a version was bumped and then effectively pushed into GitHub release.

Then we could finally publish jellyfin-webos on webosbrew apps repository.

Note that he seemingly forgot to add to the README: npm version [major|minor|path] in root directory shall now apropriately bump version in both package.json and frontend/appinfo.json, and then put that into a commit/tag. Tag pushed to GitHub repo will create a "prerelease" release with ipk/manifest files, which then will need to be marked manually as final in Releases tab.

Brice187 commented 2 years ago

Would love to see this too!

Is it possible to manually add the latest .ipk to the homebrew channel so I can permanently use jellyfin-webos without automatic updates? The licenses of jellyfin should allow this (imho).

Informatic commented 2 years ago

Sure we could do that without consulting with upstream, but we'd really like to have it here to not move stuff around multiple times. I hope someone sees that there's some interest in the community for that.

If there'll be no response in a couple following days we (webosbrew) can just fork it off, retag latest commit as v1.0.0 (since I don't see any major changes since v1.0.0 got pushed, except for CI and minor appinfo.json changes) and push it to webosbrew repo, until an official release comes out.

anthonylavado commented 2 years ago

@Informatic I'd be interested in helping make that happen. My main concern is only if this would hamper our chances of being published by LG once we submit it to the store (again).

Otherwise, I'll review your first comment and move forward with that.

Informatic commented 2 years ago

Well - if you just made an "internal" v1.0.1 release, I don't think you are contractually obligated to ship every one of them to LG, are you?

I can imagine you'll need to send an update to them at some point anyway, since I see there were some styling changes impacting webOS v1/v2?

Also I would be surprised if updates themselves were as hard to pass through the QA testing as the original release (though I never published any app on Content Store)

Unless, by "this would hamper our chances" you mean the sole fact of publishing your app on Homebrew Channel? Then... I am not sure - there have already been ipk's thrown and considering amount of stars this project has, there are multiple people using this already, from an "unofficial" distribution.

Brice187 commented 2 years ago

@anthonylavado: Creating a Github release does not affiliate you/jellyfin with an external project automatically :)

brando56894 commented 2 years ago

Getting an official/easy to install client would be great. I just bought an LG A1 for my parents, and got rid of the Nvidia Shield that they were using (too many remotes, one for the shield, one for the sound bar, one for the TV. No CEC) and told them to just use the LG Apps. My dad asked where Jellyfin was and I told him that it wasn't available on LG TVs and he'd have to use Plex. The problem is Plex is setup to stream from my library and not their local NAS which has Home Movies on it and they wouldn't want to have to keep switching servers in the UI.

anthonylavado commented 2 years ago

Will do soon. The weekend is almost here...

Perseusdehond commented 2 years ago

I haven't heard of webosbrew, what is it and/or how does it work? Because it sounds like a way to get a Jellyfin app on my LG TV soon

Informatic commented 2 years ago

See https://webosbrew.org

Easiest way of getting Homebrew Channel (unofficial app "store") working well is https://rootmy.tv - we will release an updated version in the following week that should work on all current webOS versions, so stay tuned.

On Fri, 7 Jan 2022, 19:50 Perseusdehond, @.***> wrote:

I haven't heard of webosbrew, what is it and/or how does it work? Because it sounds like a way to get a Jellyfin app on my LG TV soon

— Reply to this email directly, view it on GitHub https://github.com/jellyfin/jellyfin-webos/issues/67#issuecomment-1007651118, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIUEXUCJJ34RS3CJ6OSLILUU4YWJANCNFSM5KZ5HVMQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

anthonylavado commented 2 years ago

SDK had to be re-installed (I recently had to replace my main drive on my iMac), so I can cut a release tonight.

anthonylavado commented 2 years ago

@Informatic Does this help at all then? https://github.com/jellyfin/jellyfin-webos/releases/tag/v1.0.1

Informatic commented 2 years ago

Yes! That is perfect. I am going to file a change to webosbrew apps repo and it'll be downloadable for people with Homebrew Channel in a couple of minutes.

Informatic commented 2 years ago

@anthonylavado Ah! One other thing. Can you please untick "this is a prerelease" option in options for that Github release? We try to default to linking to "full" releases.

anthonylavado commented 2 years ago

@Informatic Done. Thanks for letting me know!

Informatic commented 2 years ago

Perfect. Everything is up now. Thank you very much for the support.

https://repo.webosbrew.org/apps/org.jellyfin.webos

capture

In case you wanted to change the description/logo URL (I couldn't find any screenshots or such), just file a PR against this file: https://github.com/webosbrew/apps-repo/blob/main/packages/org.jellyfin.webos.yml