search

jellyfin / jellyfin-webos

WebOS Client for Jellyfin
https://jellyfin.org
Mozilla Public License 2.0
638 stars 65 forks source link

Jellyfin only shows cuts the picture on tvs edge #75

Closed peterge1998 closed 2 years ago

peterge1998 commented 2 years ago

I installed the 1.01 Release yesterday and noticed this behaviour when scrolling through my library: IMG_20220121_093625015 This pic is taken after i scolled down on the default page. It seems to be cut after the first screen loads, on the tv borders. I am running webos 6.2.0-23 and the latest 10.7.x as server.

anthonylavado commented 2 years ago

Sorry for the late response. Are you using a skin or custom CSS?

We don't test against those and it's possible that they don't handle the TV layout properly.

peterge1998 commented 2 years ago

Yes. Using custom css... Any plans to respect it?

anthonylavado commented 2 years ago

The issue lies with the custom CSS maker to test their changes with the TV layout.

When you use the webOS app, it's loading the web interface exactly like you would see on the computer. When we detect that the screen size is a TV, we change from the regular desktop layout to the TV layout, which makes the cards bigger and adapts the controls to make navigation easier.

The best thing here then is if you can talk with the person who made the custom CSS and ask if they can test it on the TV layout. Depending on the changes they've made, they might have success, or they might not. LG TVs (even new ones) usually use very, very old versions of browsers (usually based off of Chrome), and these never get engine updates. So it could be difficult.

On the computer, you can manually switch to the TV layout by going to the user settings.

The steps:

anthonylavado commented 2 years ago

What skin is this? Apparently we had tried fixing scrolling once before (because it became an issue on other screens), but it ended up happening again.

peterge1998 commented 2 years ago

What skin is this? Apparently we had tried fixing scrolling once before (because it became an issue on other screens), but it ended up happening again.

Its this jellyskin skin: https://github.com/prayag17/JellySkin in an old version. But i should upgrade it, i am just hosting the css files myself to not have external requests.

anthonylavado commented 2 years ago

Yeah, it seems there was a fix at least for Tizen TVs, which also use the TV layout: https://github.com/prayag17/JellySkin/issues/49

If your copy is older than December 23 2021, then it may not have this fix. Definitely try updating it and see if it persists.

peterge1998 commented 2 years ago

Yeah, it seems there was a fox at least for Tizen TVs, which also use the TV layout: prayag17/JellySkin#49

If your copy is older than December 23 2021, then it may not have this fix. Definitely try updating it and see if it persists.

Okay, sorry for annoying, after updating the CSS files the issue is gone. Don't know if that PR fixed it, but thank you very much for taking care of this problem which is not even related to jellyfin-webos at all <3