search

jellyfin / jellyfin-webos

WebOS Client for Jellyfin
https://jellyfin.org
Mozilla Public License 2.0
638 stars 65 forks source link

Adjust screen size for 4K/8K UHD #83

Closed dmitrylyzo closed 9 months ago

dmitrylyzo commented 2 years ago

79 may return FHD (screenWidth and screenHeight) on 4K and 8K UHD.

Tested on webOS 1.2 and webOS 5.0 emulators, but still need to test on a real TV.

samcon commented 2 years ago

Seems to work on my TV (C8) as I'm getting "4K UHD is supported". Any specific test you'd like me to run?

dmitrylyzo commented 2 years ago

@samcon If you are in DevTools, please look what the value of deviceInfo.screenWidth before https://github.com/jellyfin/jellyfin-webos/blob/07a266001f7dccb6a10b933a7239394c17956b3e/frontend/js/webOS.js#L51 If it is 1920 and devicePixelRatio: 2 then it works as expected.

samcon commented 2 years ago

deviceInfo.screenWidth is already 3840 before deviceInfo.screenWidth = Math.floor(deviceInfo.screenWidth * devicePixelRatio); devicePixelRatio is of course 2.

dmitrylyzo commented 2 years ago

deviceInfo.screenWidth is already 3840 before deviceInfo.screenWidth = Math.floor(deviceInfo.screenWidth * devicePixelRatio); devicePixelRatio is of course 2.

Hmm. So is it scaled to 7680 after?

Do you see 4K options in Home network quality when Screen Resolution is selected in Maximum Allowed Video Transcoding Resolution without this PR? resolution This is in the release branch, but not released yet. If you are on 10.8.0, then it is already in the Screen resolution mode.

samcon commented 2 years ago

I'm on nightly (server and web) and I don't have "Video Settings" in that screen (only Audio and then Advanced).

dmitrylyzo commented 2 years ago

I'm on nightly (server and web) and I don't have "Video Settings" in that screen (only Audio and then Advanced).

That mode is still only in the release branch. It will probably be ported soon :crossed_fingers:

As for quality options, you probably disallowed transoding.

UPD: I forgot :man_facepalming:, https://github.com/jellyfin/jellyfin-web/pull/3343 was merged before 10.8.0. So it should be in the unstable. There is no droplist, but Screen resolution mode is active by default.

anthonylavado commented 9 months ago

@dmitrylyzo Do we still need this?

dmitrylyzo commented 9 months ago

@dmitrylyzo Do we still need this?

I guess not. According to https://github.com/jellyfin/jellyfin-webos/pull/83#issuecomment-1164646314, window.screen already has the correct values. Also, no yelling users 😅

I'm closing it for now.