jellyfin / jellyfin.org

The Jellyfin website, blog, and user documentation
http://jellyfin.org
Other
82 stars 292 forks source link

TV Shows: Document "Specials in Seasons" feature #1107

Open mihawk90 opened 3 weeks ago

mihawk90 commented 3 weeks ago

Noticed this wasn't documented anywhere, so added it.

mihawk90 commented 3 weeks ago

It's not really obvious from the setting names where the specials will play.

Really? I feel like the names are fine, but IMO the order of fields in the Metadata editor is not ideal. "Airs before Episode" (field on the right) can be used in conjunction with "Airs before Season" (field on the left) to insert it somewhere in between. But (at least logically) it can't be used with "Airs after Season" (field in the middle) because.. well, presumably it's always at the end of the season where an "airs before episode" doesn't make sense.

I'll try writing something up.

edit: Also while I'm at it... maybe someone knows for sure. If there are multiple Specials set as "airs before episode" 3 for example, I assume they are just sorted by air date? Or are they sorted by the S00EXX episode numbers? Does anyone know? I've only done this with the 3 Archer Specials above where both match up anyway.

I also just noticed you can actually fill all 3 fields, but "after Season" trumps the other 2 regardless of what was first set. Maybe not an ideal workflow (although one could argue that's a user error for inputting nonsensical data, but still).

jellyfin-bot commented 3 weeks ago

Cloudflare Pages deployment

Latest commit 7b5528c3b9e6b3211e2ad204573ba1922a64c030
Status ✅ Deployed!
Preview URL https://3167a7c0.jellyfin-org.pages.dev
Type 🔀 Preview
mihawk90 commented 3 weeks ago

Updated according to the above comments.

Should be noted that I documented it how it should work, but there is currently jellyfin/jellyfin-web#6049 where the Season's Play button doesn't behave correctly. Should that be added as a note?

felix920506 commented 3 weeks ago

is this ready for review?

mihawk90 commented 3 weeks ago

Sure, I've nothing else to add. The mentioned issue also has a pending PR for a fix so that's not needed anymore either.