jellyfin / jellyfin

The Free Software Media System
https://jellyfin.org
GNU General Public License v2.0
33.18k stars 3.02k forks source link

[Issue]: Lyrics with timestamps in 3 decimal places can't be recognized as synced #11518

Closed yoooogaQAQ closed 5 days ago

yoooogaQAQ commented 3 months ago

Please describe your bug

The synced lyrics files in my library have mixed timestamp formats, timestamp in 2 decimal places can be recognized by Jellyfin as synced, whereas timestamp in 3 decimal places cannot.

Reproduction Steps

  1. Place a LRC file next to a song file with the timestamp format like this: [00:25.831]Lorem ipsum [00:32.307]Lorem ipsum [00:38.618]Lorem ipsum
  2. Scan the library
  3. Play the song
  4. The lyrics are recognized as un-synced lyrics

Temporary solution:

  1. Truncate the timestamp to 2 decimal places
  2. The lyrics are successfully recognized as synced lyrics

Jellyfin Version

Unstable (master branch)

if other:

No response

Environment

- OS: Debian 12
- Linux Kernel: 6.1.21-v8+
- Virtualization: Docker
- Clients: Browser, Finamp
- Browser: Firefox 125.0.3
- FFmpeg Version: 6.0.1-Jellyfin
- Playback Method: Direct Play
- Hardware Acceleration: None
- GPU Model:
- Plugins:
- Reverse Proxy: Caddy
- Base URL: None
- Networking: Host
- Storage: local

Jellyfin logs

N/A

FFmpeg logs

No response

Please attach any browser or client logs here

No response

Please attach any screenshots here

1 2

Code of Conduct

jellyfin-bot commented 3 months ago

Hi, it seems like your issue report has the following item(s) that need to be addressed:

This is an automated message, currently under testing. Please file an issue here if you encounter any problems.

Shadowghost commented 3 months ago

This is an issue with the library we use.

mihawk90 commented 2 months ago

In the same vein, timestamps without decimals (i.e. [mm:ss]) are not recognised either. I haven't been able to test single-digit decimals but I wouldn't be surprised if it's affected as well.

Timestamps with triple-digit minutes (i.e. [mmm:ss.xx] which I use as tracklists on Radio Shows) are not recognised either, or rather the extracted LRC just cuts off entirely.

This is an issue with the library we use.

What library are you using, and is there an issue upstream we can track?

congerh commented 2 months ago

What library are you using

karaoke-dev/LrcParser

is there an issue upstream we can track

karaoke-dev/LrcParser#40

andy840119 commented 1 month ago

https://github.com/karaoke-dev/LrcParser/issues/40

New package update released This issue should be fixed also.

Reapor-Yurnero commented 1 month ago

Second the above. We should be able to fix this issue now!