Jellyfin API POST /Items/{itemId}/Images/{imageType} returns 400 "Incorrect ContentType."

JohnZ03 commented 1 month ago

This issue respects the following points:

[X] This is a bug, not a question or a configuration issue; Please visit our forum or chat rooms first to troubleshoot with volunteers, before creating a report. The links can be found here.
[X] This issue is not already reported on GitHub (I've searched it).
[X] I'm using an up to date version of Jellyfin Server stable, unstable or master; We generally do not support previous older versions. If possible, please update to the latest version before opening an issue.
[X] I agree to follow Jellyfin's Code of Conduct.
[X] This report addresses only a single issue; If you encounter multiple issues, kindly create separate reports for each one.

Description of the bug

API Post /Items/{itemId}/Images/{imageType} Set item image keeps returning "Incorrect ContentType." Tested with different image formats through both built-in swagger and postman. After changing in header, Content-Type: image/* to Content-Type: image/png or any other format, server returns 500 "Error processing request."

Reproduction steps

Using the built in swagger, ex: http://{server-ip}/api-docs/swagger/index.html Item id being one of the movies. Image Type set to Primary. Request body set to a png/jpeg/jpg movie poster.

What is the current bug behavior?

400 server response, and the item image cannot be set.

What is the expected correct behavior?

200 server response, item's image updated.

Jellyfin Server version

Older*

Specify commit id

No response

Specify unstable release number

No response

Specify version number

10.9.8

Specify the build version

10.9.8

Environment

Docekr build

Jellyfin logs

N/A

FFmpeg logs

No response

Client / Browser logs

No response

Relevant screenshots or videos

No response

Additional information

No response

JohnZ03 commented 1 month ago

The "Incorrect ContentType." 400 response comes from the function below: https://github.com/jellyfin/jellyfin/blob/4363cbd88bd890bec8d1934bf93808ebaf461ff0/Jellyfin.Api/Controllers/ImageController.cs#L347-L372 Where it uses a parsing function to determine the file extension: https://github.com/jellyfin/jellyfin/blob/4363cbd88bd890bec8d1934bf93808ebaf461ff0/Jellyfin.Api/Controllers/ImageController.cs#L2124-L2142

If anyone have a testing environment, could you please check if the function "TryGetImageExtensionFromContentType" is behaving correctly?

I'm also trying to clone and test but it might take a while.

Thanks for any help in advance.

gnattu commented 1 month ago

You should not use image/* as mime type and you should explicitly set the image type like image/png
The body should be the base64 encoded string of the image, not the binary value of the image.

From what you described I have an impression that you are using this API endpoint wrong.

JohnZ03 commented 1 month ago

Well thanks a lot, I did not see any part about the body type in the doc, will test and see if I can update the documentation as well. @gnattu

JohnZ03 commented 1 month ago

Can confirm it's working now, thanks so much for the help. @gnattu

jellyfin / jellyfin