jellyfin / jellyfin

The Free Software Media System
https://jellyfin.org
GNU General Public License v2.0
34.22k stars 3.12k forks source link

[Issue]: People thumbnails are large and take up a lot of unnecessary disk space, so should be downscaled #9069

Closed Webreaper closed 1 year ago

Webreaper commented 1 year ago

Please describe your bug

The thumbnails displayed for people can be extremely large (over 1MB) because they're pulled directly from the metadata sources such as TMDB, but are not rescaled when JF caches them locally. This can result in hundreds of MB of unnecessary storage being wasted locally.

Jellyfin should really scale them down to some sensible max size, so that they're all no more than a couple of hundred KB or less.

You probably already have thumbnail scaling code in the codebase - if not, please feel free to steal mine: https://github.com/Webreaper/Damselfly/blob/master/Damselfly.Core.ImageProcessing/SkiaSharpProcessor.cs#L25 (I seem to remember that JF uses Skiasharp to do its image manipulation). It would be trivial to feed a stream into that code so that the JF code that downloads the thumbs would automatically pass it through a downscaling filter before writing it to disk in /metadata/People.

Related: https://github.com/jellyfin/jellyfin/issues/5344 - this may also prevent space being wasted on JF mobile clients running on phones, where it also seems the thumbs are sent without any scaling.

Jellyfin Version

10.8.0

if other:

No response

Environment

- OS:
- Virtualization:
- Clients:
- Browser:
- FFmpeg Version:
- Playback Method:
- Hardware Acceleration:
- Plugins:
- Reverse Proxy:
- Base URL:
- Networking:
- Storage:

Jellyfin logs

No response

FFmpeg logs

No response

Please attach any browser or client logs here

No response

Please attach any screenshots here

No response

Code of Conduct

jellyfin-bot commented 1 year ago

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.

If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or master branch, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.

This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

DaCHack commented 1 year ago

@Webreaper made a good point here. Anything happened on this already?