jellyflix-app / jellyflix

Jellyfix is an easy-to-use Jellyfin client for movies and shows. It's cross-platform and supports Mobile (iOS, Android) and Desktop (Windows, Mac, Linux).
https://jellyflix.kiejon.com
GNU General Public License v3.0
158 stars 26 forks source link

Login error handling #124

Closed RA341 closed 1 week ago

RA341 commented 2 weeks ago

Changes

Added support for autofill so that password managers can autofill credentials.

Ui changes

Default error handling UI.

default

Specific error messages for certain HTTP codes. If a response does not match a specific code, it defaults to the normal UI.

err

Added a check for empty inputs.

missing

Bug fix

There was also a bug in the auth logic

The if condition adds a port regardless of the protocol, which will cause a tls mismatch error if we put https address and the error handler adds the port.

relevant line

if (user.serverAdress!.split(":").last != "8096" &&
          user.serverAdress!.split(":").length == 2 

adds a HTTP check

if (user.serverAdress!.split(":").last != "8096" &&
          user.serverAdress!.split(":").length == 2 &&
          user.serverAdress!.split(":").first == 'http')
sevenrats commented 2 weeks ago

if you were open to fixing this while you were mucking about in this view that would be very helpful: https://github.com/jellyflix-app/jellyflix/issues/63

RA341 commented 2 weeks ago

if you were open to fixing this while you were mucking about in this view that woul

if you were open to fixing this while you were mucking about in this view that would be very helpful: #63

I got it

63 is implemented

sevenrats commented 2 weeks ago

looks great works great. sorry this didn't occur to me earlier, but, jellyfin actually supports empty passwords. for example this branch now prevents jellyflix from accessing the demo server at https://demo.jellyfin.org/stable image

RA341 commented 1 week ago

removed the password check

sevenrats commented 1 week ago

@jdk-21 I'm plus one on this when you are ready to review.

RA341 commented 1 week ago

adding this one last change, to show URLs tried

image