jellypbc / poster

Jelly demo toy app that turns PDFs into editable posts
https://jellypbc.com
Other
22 stars 3 forks source link

Comments #336

Closed cindywu closed 3 years ago

cindywu commented 4 years ago

This PR matches the Comment Design System: https://www.figma.com/file/gt3p3JDh5W5i5N2wXxE7I5/Design-System?node-id=0%3A1

future

linear[bot] commented 4 years ago
JEL-221 comments

* [X] add comment count to top of comment container * [X] move code rendering comments from `comments.js`to `CommentContainer.js` * [X] create `Comment.js` component * [X] move `handleReplySubmit`and `handleReplyCancel`from `Comment.js`to `comments.js` * [ ] guest registration styles * [ ] stick comment in right gutter with width of `col-md-3` * [ ] move delete to ellipsis dropdown * [ ] fix the can't comment copy text issue! * [ ] fix pasting issue! * [ ] markdown in comments * [ ] math in comments * [ ] hover over highlighted text, see comment number in sidebar * [ ] fix avatar for logged out users… no avatar for logged out user * [ ] clean up `comments.scss` [Comment - Design System (Figma)](https://www.figma.com/proto/gt3p3JDh5W5i5N2wXxE7I5/Design-System?node-id=23%3A0&viewport=-3603%2C170%2C0.3872848153114319&scaling=min-zoom) ![image.png](https://uploads.linear.app/5522bd94-0037-4b38-9adb-1a67abf87e7b/5eb76c8e-4bed-4780-9ffd-487a5b0bf0b7/image.png "image.png")

cindywu commented 4 years ago

WIP Kapture 2020-10-31 at 14 10 03

cindywu commented 4 years ago

guest commenting UX Kapture 2020-10-31 at 18 08 49

cindywu commented 4 years ago

WIP shows highlighted text in comment container

Kapture 2020-10-31 at 22 44 37

cindywu commented 3 years ago

Closing this PR. We are migrating to Typescript https://github.com/jellypbc/poster/pull/404, so I will restart this PR to avoid the mess.