Open jellywaiyan opened 9 months ago
A module requirement is for there to be a sufficient number of examples. Hence we tried to make it consistent with just one example for all commands.
We already mentioned that some fields are optional and it is not meaningful to add all combinations for the optional fields. In the editPerson’s example, there is inclusion of two fields to edit, hence it shows the purpose of editing multiple fields clearly. Hence, it is self explanatory for the reader to modify the example as they see fit and we believe that this inconsistency does not hinder users.
Team chose [response.NotInScope
]
Reason for disagreement: [replace this with your explanation]
For some commands with optional parameters, the example command for it includes all the optional parameters. However, for some other commands, the example does not include all optional parameters, which is a bit inconsistent.
I think this would be a good example. For edit person, there are many optional parameters that were not included in the example.![Screenshot 2023-11-17 at 5.37.00 PM.png](https://raw.githubusercontent.com/jellywaiyan/pe/main/files/cba3408a-c5e2-4095-b187-2470331cd970.png)
However, for edit task, all the optional parameters are included![Screenshot 2023-11-17 at 5.35.28 PM.png](https://raw.githubusercontent.com/jellywaiyan/pe/main/files/c111e9cf-ded4-4dc8-a88d-a6288b555674.png)