jellywaiyan / pe

0 stars 0 forks source link

Allowance of persons with same name, but different capitalisations #2

Open jellywaiyan opened 9 months ago

jellywaiyan commented 9 months ago

I feel that persons with the same exact name should not be allowed (or rather, the name field should be case insensitive), and instead have an identifier attached to the name such as John Doe (CS) or John Doe (NYJC), as it may be hard to differentiate between two people such as John Doe and JoHn Doe.

Screenshot 2023-11-17 at 4.33.55 PM.png

Screenshot 2023-11-17 at 4.34.04 PM.png

soc-se-bot commented 9 months ago

Team's Response

It can be done on many contact applications which consider names of different capitalisations as distinct contacts.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

No duplicate detection for 'John' and 'john'

image.png There is no duplicate detection for "John Doe" and "john doe" though they are likely to be the same person.


[original: nus-cs2103-AY2324S1/pe-interim#1020] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It's not necessary for our system to consider 'John Doe' and 'john doe' as duplicates, because many contact applications treat contacts with different capitalizations as distinct entries.

Consider this scenario with an Android contact application: "john Doe" and "John Doe" are recognised as separate contacts. This practice is standard among many major phone applications, and our application follows this norm. Furthermore, we have stressed that the name field is case-sensitive within the user guide.

Screenshot 2023-11-20 at 1.35.27 AM.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]