jellywaiyan / pe

0 stars 0 forks source link

Findperson / tag / task should also follow restrictions placed on addperson/tag/task #5

Open jellywaiyan opened 9 months ago

jellywaiyan commented 9 months ago

The restriction placed on names,tags and tasks are that only alphanumeric characters are allowed ap n/. p/93843333 e/test@gmail.com a/Test addy Screenshot 2023-11-17 at 4.52.52 PM.png

However, if we do ft . or fp . or ftag ., the command goes through and shows nothing (since we have no names or tags or tasks with .) Screenshot 2023-11-17 at 4.53.13 PM.png

Screenshot 2023-11-17 at 4.53.32 PM.png

I feel like putting in non-alphanumeric characters when finding should result in an error message, which would be the same error message as the specific field eg. fp . should show the error shown in the first screenshot and not go through

soc-se-bot commented 9 months ago

Team's Response

Bug #4961

Thank you for your bug report.

For findPerson, we have a planned enhancement in the Developer Guide to allow non-alphanumeric characters in Person's names.

To be consistent with this planned enhancement, all other find commands will follow the format of findPerson (i.e. accept non-alphanumeric characters) so that the user does not need to remember which find command accepts non-alphanumeric characters and which do not. This makes the user experience more smooth and intuitive.

For findTask, currently, a task's title and note can already contain non-alphanumeric characters, so the suggestion is invalid.

We hope that you understand our decision. Thank you.

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]