search

jelmer / dulwich

Pure-Python Git implementation
https://www.dulwich.io/
Other
2.06k stars 395 forks source link

Support git config proxy settings #1368

Closed shcheklein closed 1 month ago

shcheklein commented 1 month ago

Inspired by https://github.com/iterative/dvc/issues/10563

I think it would be great to automatically support:

$ git config --global http.proxy http://proxy.address.com:port/
$ git config --global https.proxy http://proxy.address.com:port/

the same way it support HTTP_PROXY and HTTPS_PROXY .

jelmer commented 1 month ago

This is already supported, see https://github.com/jelmer/dulwich/blob/master/dulwich%2Fclient.py#L2165

jelmer commented 1 month ago

How are you using the Dulwich client library? Is there config being passed in, do you have a custom http client?

shcheklein commented 1 month ago

Yes, you are right, and I see that we do have a custom HTTP client (probably bc this was not merged https://github.com/jelmer/dulwich/pull/976 ). Let me see if there is a way to all pass proxy_headers there ...

shcheklein commented 1 month ago

Since it's not related to dulwich, let me close the ticket for now. Thanks @jelmer !

jelmer commented 1 month ago

Yes, you are right, and I see that we do have a custom HTTP client (probably bc this was not merged https://github.com/jelmer/dulwich/pull/976 ). Let me see if there is a way to all pass proxy_headers there ...

Ah, sorry - I think that slipped off my radar.