Closed kloczek closed 2 years ago
And yet another minor issue. Sphinx shows one warning
+ /usr/bin/sphinx-build -n -T -b man docs build/sphinx/man
Running Sphinx v4.5.0
making output directory... done
building [mo]: targets for 0 po files that are out of date
building [man]: all manpages
updating environment: [new config] 14 added, 0 changed, 0 removed
reading sources... [100%] tutorial/tag
/home/tkloczko/rpmbuild/BUILD/dulwich-dulwich-0.20.38/docs/api/index.txt:6: WARNING: toctree contains reference to nonexisting document 'api/modules'
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
writing... python-dulwich.3 { performance protocol tutorial/index tutorial/introduction tutorial/encoding tutorial/file-format tutorial/repo tutorial/object-store tutorial/remote tutorial/tag tutorial/porcelain tutorial/conclusion api/index } done
build succeeded, 1 warning.
As mentioned in the other ticket, dulwich doesn't use pytest (please run "make check" instead, which will ) though I'm happy to consider pull requests to make dulwich work with pytest, just like any other third party test runners.
As discussed in the other ticket, please run "make -C docs html" to build the sphinx documentation rather than invoking sphinx directly.
pytest is able to handle unittest test suite however because it is not extended any more pytest shows now some warnings. Using pytest instead ubittest has other advantages.
I don't want to revisit the discussion we had earlier; I'm using other tools than pytest, which are working for me. If you're interested in contributing to Dulwich and would prefer to run a different test runner, I'd consider PRs that fix that test runner.
If you're merely packaging dulwich I'd encourage you to just invoke "make check" - that's the most likely to actually work, because that's what we as upstream use.
Tested new 0.20.42 it is now clean.
To be honest still I have some issue with dulwich/contrib/test_swift_smoke.py which I'm adding to --ignore list because all those units are complaining about configuration file. Should I let this on --ignore list or ca I alter somehow testing procedure to pass that missing configuration? 🤔
You can set the environment variables to run those tests - but you'll need a swift setup to do so I believe.
You can set the environment variables to run those tests - but you'll need a swift setup to do so I believe.
unittest
test suite can be handled by pytestpython -m foo
in case of unittest
and pytest
is wrong because when python executes that way module it adds current directory to sys.path
. This is why pytest
and unittest
provides standalone pytest
and unittest
scriptunittest
is no longer maintained and this is why +90% of all modules switched to pytest.unittest is still a part of standard python, and pytest is not. I'm pretty sure it's still maintained, even if it's not getting new features.
None of the projects I work on use pytest, and I'm pretty sure the majority of projects I contribute to don't use pytest.
The tests in Dulwich are compliant with unittest and run fine with it.
I'm tired of rehashing this discussion over and over in various projects - these issues are just a distraction from useful work on Dulwich - they're not actually telling us anything new. So I'm going to close this issue.
Indeed it is however accordig to stats from my +950 packages python modules it is used in less than 0.1% cases.
And again: correctly written unittest
test suite can be handled by latest pytest.
Pytest even poits on what is wrong ..
I've been flagging that in https://github.com/jelmer/dulwich/issues/874 but ticket is alredy closed 😞
I'm trying to package your module as an rpm package. So I'm using the typical PEP517 based build, install and test cycle used on building packages from non-root account.
python3 -sBm build -w --no-isolation
build
with--no-isolation
I'm using during all processes only locally installed modulesHere is pytest output:
I'm assuming that for those units which are ending with error something still is missing in my testing procedure. If may I ask for some hints what excly is missing .. 😄