search

jelmer / setuptools-protobuf

protobuf support for setuptools
Apache License 2.0
14 stars 5 forks source link

Add feature to download a specific protoc version #25

Closed sassy-asjp closed 11 months ago

sassy-asjp commented 11 months ago

Adds feature #24

If protoc_version is specified, that particular version is downloaded as part of the build. It is not cached across pip tmp build environments, but will only be downloaded once per pip tmp build environment.

If protoc_version is not specified, it uses the old behavior of using the pre-installed version via either PROTOC environment variable, or system default.

I have tested this on darwin/aarch64, linux/aarch64, and linux/amd64.

jelmer commented 11 months ago

Can you take a look at the test failures?

sassy-asjp commented 11 months ago

@jelmer Ah flake8 was unhappy. I fixed the issues and flake8 passes locally, so it should pass now.

sassy-asjp commented 11 months ago

I pushed another commit for failing tests python <3.10