language tag <-> canonical language tag confusion with TranslateLocally

jelmervdl / translatelocally-web-ext

TranslateLocally for the Browser is a web-extension that enables client side in-page translations for web browsers.

https://addons.mozilla.org/en-GB/firefox/addon/translatelocally-for-firefox/

Mozilla Public License 2.0

65 stars 3 forks source link

language tag <-> canonical language tag confusion with TranslateLocally #25

Open jelmervdl opened 2 years ago

jelmervdl commented 2 years ago

The Ukrainian models don't work because of uk <-> ukr confusion.

translateLocally already accepts unique model identifiers instead of ambiguous language tags, but I haven't implemented that bit yet in this extension.

Probably caused by this bit:

https://github.com/jelmervdl/firefox-translations/blob/2181bf7852cce61fab70565c3b9d5ecbebeee1ad/extension/controller/translation/TLTranslationHelper.js#L122-L131