Open jelmervdl opened 2 years ago
The Ukrainian models don't work because of uk <-> ukr confusion.
translateLocally already accepts unique model identifiers instead of ambiguous language tags, but I haven't implemented that bit yet in this extension.
Probably caused by this bit:
https://github.com/jelmervdl/firefox-translations/blob/2181bf7852cce61fab70565c3b9d5ecbebeee1ad/extension/controller/translation/TLTranslationHelper.js#L122-L131
The Ukrainian models don't work because of uk <-> ukr confusion.
translateLocally already accepts unique model identifiers instead of ambiguous language tags, but I haven't implemented that bit yet in this extension.
Probably caused by this bit:
https://github.com/jelmervdl/firefox-translations/blob/2181bf7852cce61fab70565c3b9d5ecbebeee1ad/extension/controller/translation/TLTranslationHelper.js#L122-L131