search

jelmervdl / translatelocally-web-ext

TranslateLocally for the Browser is a web-extension that enables client side in-page translations for web browsers.
https://addons.mozilla.org/en-GB/firefox/addon/translatelocally-for-firefox/
Mozilla Public License 2.0
65 stars 3 forks source link

Disconnect from native client when destroying TLTranslationHelper instance #31

Closed jelmervdl closed 1 year ago

jelmervdl commented 2 years ago

When switching translation providers, the switching doesn't stop the translateLocally instance running in the background.

Same thing occurs in the benchmark: any translateLocally instances used for any of the runs will remain active (albeit dormant, but still using memory) while the benchmark page is open.

jelmervdl commented 1 year ago

Implemented in 70593b1d918f38af9880b64da9bb0923d2a91a29 and ded7076aa0b4188ea5817aded0620956d834a150.