search

jelockwood / pinpoint

A script for finding your Mac
GNU General Public License v3.0
28 stars 5 forks source link

Bug fix to reduce API calls #10

Closed ofirgalcon closed 1 year ago

kevinmcox commented 1 year ago

@jelockwood I'm pretty sure this PR can be closed as the code got merged by you directly.

jelockwood commented 1 year ago

If you download the current version and try it you can see if that is correct. Alternatively you can do a DIFF of my current version against yours to see if there are still things to do.

If your changes still need to be made then I could manually add them and we can then cancel all your submissions and see if we can get back in sync. I would need to 'borrow' your API key again to do that.

Let me know what you think.

Regards, John

On Fri, Dec 16, 2022 at 9:16 PM Kevin M. Cox @.***> wrote:

@jelockwood https://github.com/jelockwood I'm pretty sure this PR can be closed as the code got merged by you directly.

— Reply to this email directly, view it on GitHub https://github.com/jelockwood/pinpoint/pull/10#issuecomment-1355620384, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAZ74XI5OXIF27ACDLOLKTWNTL4PANCNFSM4XB7GN6Q . You are receiving this because you were mentioned.Message ID: @.***>

--

[image: View my profile on LinkedIn]View John Lockwood's profile http://uk.linkedin.com/in/jelockwood/

kevinmcox commented 1 year ago

I confirmed with @ofirgalcon in the MacAdmins Slack that the current "release" version of the script matches the code he is using in production.

jelockwood commented 1 year ago

@kevinmcox @ofirgalcon I made the commit to include the typo fix submitted by @kevinmcox I have now also made a commit for the fix submitted by @ofirgalcon

As this now includes a fix I have built a new installer package and upped the version number to 3.2.1 and made this a new release.

I use Packages to build the installer pkg and it built with no errors reported but I have not tried actually running the installer pkg myself.

Can one or both of you give it a go and let me know if there is an issue?

PS. @ofirgalcon I closed your previous commits which @kevinmcox indicates are actually now in the release version already - let me know if you think there are still missing ones. As you might gather from the above this time your commit was accepted by GitHub with no complaints. Hopefully this means future commits will also be accepted.

kevinmcox commented 1 year ago

@jelockwood 3.2.1 package looks good here.