jelockwood / pinpoint

A script for finding your Mac
GNU General Public License v3.0
28 stars 5 forks source link

Bug fixes #7

Closed kevinmcox closed 3 years ago

kevinmcox commented 3 years ago

• Quoted "$resultcode" to prevent line 175: [: too many arguments error

• Changed LS_Enabled from a boolean to an integer to fix MunkiReport error: Server Error: SQLSTATE[HY000]: General error: 1366 Incorrect integer value: '' for column 'ls_enabled' at row 1

See @bochoven comment, "The database implementation that MR uses does not have boolean as a storage type" in discussion at https://macadmins.slack.com/archives/C066NK3K5/p1580221740182600\

kevinmcox commented 3 years ago

I can build the package and send it your way if you'd like.

jelockwood commented 3 years ago

Let me see if I can do it over the weekend.

Note: It does not contain your previous enhancements just this months changes.

On Thu, Oct 22, 2020 at 5:07 PM Kevin M. Cox notifications@github.com wrote:

I can build the package and send it your way if you'd like.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/jelockwood/pinpoint/pull/7#issuecomment-714597432, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAZ74VHTOHBTTSVTK3L3MTSMBKCPANCNFSM4SW6RKAA .

--

[image: View my profile on LinkedIn]View John Lockwood's profile http://uk.linkedin.com/in/jelockwood/

jelockwood commented 3 years ago

Hi. I have built the pkg and attached it to the 3.0.4 release, I have not however tried running it but the build showed no errors.

I mention this because I built it on a different laptop this time. If you can let me know if there are any problems with it.

On Thu, Oct 22, 2020 at 5:07 PM Kevin M. Cox notifications@github.com wrote:

I can build the package and send it your way if you'd like.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/jelockwood/pinpoint/pull/7#issuecomment-714597432, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAZ74VHTOHBTTSVTK3L3MTSMBKCPANCNFSM4SW6RKAA .

--

[image: View my profile on LinkedIn]View John Lockwood's profile http://uk.linkedin.com/in/jelockwood/

kevinmcox commented 3 years ago

The package receipt got changed on this newest build.

Previously it was com.jelockwood.pinpoint.pkg. but the newest version is missing the trailing period so it doesn't evaluate as an upgrade of the previous install.

jelockwood commented 3 years ago

@kevinmcox I have uploaded a replacement with the same version number but the trailing period. Let me know if that does the job.

kevinmcox commented 3 years ago

The receipt looks good and matches the previous one.