Add default values to functions

jelovac / bitly4laravel

Provides a Laravel package to communicate with Bit.ly API

35 stars 18 forks source link

Closed carnevalle closed 10 years ago

carnevalle commented 10 years ago

The bit.ly API has default values for their API-calls but this package requires you to provide all the parameters.

It would be convenient if the package mirrored the API, so that:

public function linkClicks($link, $unit, $units, $timezone, $rollup, $limit, $unitReferenceTimeStamp)

becomes

public function linkClicks($link, $unit = null, $units = null, $timezone = null, $rollup = null, $limit = null, $unitReferenceTimeStamp = null)

jelovac commented 10 years ago

Thanks for reporting this the most of the methods have their default value, I might skipped some will add a fix ASAP.

jelovac commented 10 years ago

This should be fixed now.

Change log:

Added few missing methods (domainBitlyProDomain, userTrackingDomainClicks, userTrackingDomainShortenCounts, nsqStats)
Modified existing methods were parameters were required but in the bitly API are optional
Modified function info($shortURLOrHash, $expandUser = null), merged two separate parameters (url and hash)