jely2002 / youtube-dl-gui

A cross-platform GUI for youtube-dl made in Electron and node.js
GNU Affero General Public License v3.0
6.65k stars 471 forks source link

"Show File in Folder" & "Open File" buttons aren't working #305

Open GT2000byte opened 2 years ago

GT2000byte commented 2 years ago

When downloading YouTube videos, both buttons don't work. It seems like the software is looking for a .webm file instead of a .mp4/.mkv file. Haven't checked if it's the same on other websites, but I can confirm it's happening with YT videos and audios.

  1. Download any YouTube video
  2. Let the download finish
  3. Click on either option
  4. For "Show File..." it refuses to work. As for "Open File", the message "Windows cannot find Open Video Downloader downlaods route .webm " pops up.

    • OS: Windows 11
    • Application version 2.4.0
    • Application type: Portable version
PowerOfSam commented 2 years ago

Same problem here. When trying to open file, program tries to open webm file instead of mp4/mkv. Show in folder button don't work .Same with audio only/video only.

Altonss commented 2 years ago

Same problem here on MacOS and Linux

s23301955 commented 2 years ago

Same problem here on Windows 10 20H2

shanebrowncs commented 2 years ago

This problem seems to be coming from setFilename in Video.js. Youtube-dlp appears to have changed their output prefix from [ffmpeg] to names matching the actual operation ([download], [ExtractAudio], etc.).

I'm sure there's a better way to do this than trying to extract the filename/extension from ffmpeg's output but if setFilename were to look for the operation name without bothering with the prefix that is probably good enough. If this issue isn't addressed quickly I'll try working on a pull request.

Firefox0 commented 2 years ago

This issue annoyed me as well. I created a pull request with a fix for both buttons. I never got an error message when I tried to open a file though. Instead, the button just didn't do anything at all.

Elaws commented 2 years ago

Same problem, 6 months after this issue was opened :/