jely2002 / youtube-dl-gui

A cross-platform GUI for youtube-dl made in Electron and node.js
GNU Affero General Public License v3.0
6.5k stars 454 forks source link

Remove `windows-32` ffmpeg download #376

Open richardsondev opened 2 years ago

richardsondev commented 2 years ago

Issue

When os.arch() == ia32 we try to download windows-32 ffmpeg but on ffbinaries it no longer exists: https://ffbinaries.com/api/v1/version/latest

From investigation, this is by design on their end and they will not provide 32-bit Windows binaries anymore.

On the Windows 11 x64 machine I am building on, os.arch() is returning ia32 and os.platform() returns win32 which is leading to ffmpeg to not automatically download as it attempts to download the windows-32 binary.

os.arch() and os.platform() from console.log: image

But this is a 64-bit machine: image

This change

This PR is removing windows-32 ffmpeg downloading since the link doesn't exist anymore. On my local Windows 11 x64 machine, it is now successfully downloading ffmpeg automatically from windows-64.

We could also find a new source for 32-bit Windows ffmpeg but from my investigation, the usage of 32-bit Windows is low. At least on Steam, 32-bit Windows is only 0.18% of Windows machines: https://store.steampowered.com/hwsurvey/

0.18% = (0.12+0.05)*100/96.68

Tests

image